From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72897C8255F for ; Mon, 16 Nov 2020 15:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F29FF2344C for ; Mon, 16 Nov 2020 15:02:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="IfCTlik9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731378AbgKPPCj (ORCPT ); Mon, 16 Nov 2020 10:02:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731370AbgKPPCe (ORCPT ); Mon, 16 Nov 2020 10:02:34 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63C75C061A47 for ; Mon, 16 Nov 2020 07:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uNt4M6blJde8bHOvi0a0yCMpEmKGhZIOtOO8+7FVTWY=; b=IfCTlik97c9yFX+9NdQZyHXA5 nvr5kPUpRGrBYTpeNHU05KfrR12d5PFGFUM4Ip5VeQp4TrD/osoxClj5FpDza85RC1adFCUvulDyL hrQyYP+TfYiBo2/Ker2IdDpjumuttlLFfxGNKCwbRQk0ohm9fgV3l4aAGsf8FgtpblN9lq317UXqt gG7uKgogq8slQAZNr8SlCC6ZF8SN9Z/RzhAsHRvT1X5KzJBUmzcv9lyJEZ99emck8TjVsgab8ltoe n6H0MtwLS8MuN/CnVl5CnZnPf9zKvgpx92xcoLWl7SMXgGO2OP3Bq4kvmb0H23sXbgQn+4lhh8sB2 kF/QBhwAQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60446) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keg1J-0007Q6-FI; Mon, 16 Nov 2020 15:02:17 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1keg1I-0007Y9-HR; Mon, 16 Nov 2020 15:02:16 +0000 Date: Mon, 16 Nov 2020 15:02:16 +0000 From: Russell King - ARM Linux admin To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, davem@davemloft.net, Jakub Kicinski , Andrew Lunn Subject: Re: [PATCH net-next v3 4/5] net: phy: marvell10g: change MACTYPE if underlying MAC does not support it Message-ID: <20201116150216.GK1551@shell.armlinux.org.uk> References: <20201116111511.5061-1-kabel@kernel.org> <20201116111511.5061-5-kabel@kernel.org> <20201116154552.5a1e4b02@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201116154552.5a1e4b02@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Nov 16, 2020 at 03:45:52PM +0100, Marek Behún wrote: > Hi Russell, > > previously you replied on this patch: > > > This'll do as a stop-gap until we have a better way to determine which > > MACTYPE mode we should be using. > > Can we consider this as Acked-by ? Not really. The selection of MACTYPE isn't as simple as you make out in this patch. If we know that the MAC supports 2500BASE-X and/or SGMII, that means MACTYPES 0, 3, 4, 5 are possible to fit that, all likely will work if we restrict the PHY to either 2.5G only or 1G..10M only. However, it only becomes important if the faster speeds are supported at the MAC. I'm afraid I haven't put much thought into how to solve it, and as I'm totally demotivated at the moment, that's unlikely to change. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!