From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18045C388F9 for ; Tue, 17 Nov 2020 02:50:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C98EB2467B for ; Tue, 17 Nov 2020 02:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726086AbgKQCtm (ORCPT ); Mon, 16 Nov 2020 21:49:42 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:59258 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgKQCtl (ORCPT ); Mon, 16 Nov 2020 21:49:41 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ker3o-007SRm-N0; Tue, 17 Nov 2020 03:49:36 +0100 Date: Tue, 17 Nov 2020 03:49:36 +0100 From: Andrew Lunn To: Tobias Waldekranz Cc: davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next 1/3] net: dsa: tag_dsa: Allow forwarding of redirected IGMP traffic Message-ID: <20201117024936.GI1752213@lunn.ch> References: <20201114234558.31203-1-tobias@waldekranz.com> <20201114234558.31203-2-tobias@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201114234558.31203-2-tobias@waldekranz.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Nov 15, 2020 at 12:45:56AM +0100, Tobias Waldekranz wrote: > When receiving an IGMP/MLD frame with a TO_CPU tag, the switch has not > performed any forwarding of it. This means that we should not set the > offload_fwd_mark on the skb, in case a software bridge wants it > forwarded. > > This is a port of: > > 1ed9ec9b08ad ("dsa: Allow forwarding of redirected IGMP traffic") > > Which corrected the issue for chips using EDSA tags, but not for those > using regular DSA tags. > > Signed-off-by: Tobias Waldekranz Reviewed-by: Andrew Lunn Andrew