From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221F4C5519F for ; Wed, 18 Nov 2020 11:58:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B9AA2463B for ; Wed, 18 Nov 2020 11:58:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rJ4WRtKj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725781AbgKRL6L (ORCPT ); Wed, 18 Nov 2020 06:58:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726985AbgKRL6L (ORCPT ); Wed, 18 Nov 2020 06:58:11 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73B7EC0613D6 for ; Wed, 18 Nov 2020 03:58:11 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id s2so855167plr.9 for ; Wed, 18 Nov 2020 03:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e06oOc4RuN9P/VUU47/az/twPX9Nm/1HhyjblwKfkfc=; b=rJ4WRtKjq35dZeXZ/KnjA5BgQRm9ykoN8E9JxwoLFc1PPL6QTX2bGTMnj2B18gDS9s X08ShvHS6cm0MdphMq4GiPidBOkeripf4zvRohtAE0TwAPAwXL9cxhp27ZglYNtcwma1 erzKG8P7y3FnE60LdVZDQfT7Titled2vLawqr0Nb/fHKHJq8PMgcaYm/Xu7HvT+G6qZ9 CwdDPy4fn1wGdRQgEhuknnaiLT4fDTpEK5eaLmcBAL42jbVPt9TfrsLd+jKfpETs4Hat S0Cd9ftNEC5FmwoaDojbNqRwdJXvfF+xSTu5H4omygtP/vOyVANprxUVKQG4S9+JIArW dzFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e06oOc4RuN9P/VUU47/az/twPX9Nm/1HhyjblwKfkfc=; b=ZV2bvTabarzeLpQ63mozGWxuJRhdF/HhQGox+GIe3n6GP2+TfYFS2TNIImo8zxxfSZ 5B7pnqZ41HwclE32FvQBRO/ACFqm1MqnRIiVJ1FcULN8tnZAIhQpvOV9KL9eoSdwpqdH hPtSyLaRnmeXhnnkPETPDQOEKZhZA42qMSQuNeKpD9ugcVeyXrEkf3JtLoSzqc30Emuu VwU2Lsj7aC89E7qa256PARH8bK3MfoybpSpi2DzzC/QHagOIq1rqMF+tEi8l+s36/0eN Z8odQMsZ62KD1qRoPxG3bTJA1FeXegRr1hLD4sQkgj9qqyV8MC/zXpDE/kF36ZEZb83E Xi7Q== X-Gm-Message-State: AOAM531UKbSc49CkzXFCxICLLaY4AdPZCzFU0i/AY+gPceGy5rgBv1uN s6W0XFbEtaFa1x5wj6omXJ0y X-Google-Smtp-Source: ABdhPJzPbm+WpLJrhor1bhcpiLpWMeJs6GI8+XTAXmGwyaJPfgNUpD3nptdMl8hGGNk/ULnzpQ9ovA== X-Received: by 2002:a17:90a:7e94:: with SMTP id j20mr3572429pjl.187.1605700690813; Wed, 18 Nov 2020 03:58:10 -0800 (PST) Received: from thinkpad ([2409:4072:6e00:1c8c:4ce:9ec5:283d:8090]) by smtp.gmail.com with ESMTPSA id x18sm24230235pfi.206.2020.11.18.03.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 03:58:10 -0800 (PST) Date: Wed, 18 Nov 2020 17:27:57 +0530 From: Manivannan Sadhasivam To: Carl Huang Cc: Kalle Valo , Loic Poulain , linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org, bbhatt@codeaurora.org, netdev@vger.kernel.org, hemantk@codeaurora.org, ath11k@lists.infradead.org Subject: Re: [PATCH] bus: mhi: Remove auto-start option Message-ID: <20201118115757.GA5680@thinkpad> References: <20201118053102.13119-1-manivannan.sadhasivam@linaro.org> <877dqjz0bv.fsf@codeaurora.org> <20201118093107.GC3286@work> <16c430bbd5117a35496f85f4454095b9@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16c430bbd5117a35496f85f4454095b9@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Nov 18, 2020 at 07:55:19PM +0800, Carl Huang wrote: > On 2020-11-18 17:31, Manivannan Sadhasivam wrote: > > On Wed, Nov 18, 2020 at 07:43:48AM +0200, Kalle Valo wrote: > > > Manivannan Sadhasivam writes: > > > > > > > From: Loic Poulain > > > > > > > > There is really no point having an auto-start for channels. > > > > This is confusing for the device drivers, some have to enable the > > > > channels, others don't have... and waste resources (e.g. pre allocated > > > > buffers) that may never be used. > > > > > > > > This is really up to the MHI device(channel) driver to manage the state > > > > of its channels. > > > > > > > > While at it, let's also remove the auto-start option from ath11k mhi > > > > controller. > > > > > > > > Signed-off-by: Loic Poulain > > > > Reviewed-by: Manivannan Sadhasivam > > > > [mani: clubbed ath11k change] > > > > Signed-off-by: Manivannan Sadhasivam > > > > > > Thanks and feel free to take this to the immutable branch: > > > > > > Acked-by: Kalle Valo > > > > Patch applied to mhi-ath11k-immutable branch and merged into mhi-next. > > > > Thanks, > > Mani > > > Does net/qrtr/mhi.c need changes? I guess now net/qrtr/mhi.c needs to call > mhi_prepare_for_transfer() before transfer. > Yes and the patch is also applied: https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/commit/?h=mhi-ath11k-immutable&id=a2e2cc0dbb1121dfa875da1c04f3dff966fec162 Thanks, Mani > > > > > > -- > > > https://patchwork.kernel.org/project/linux-wireless/list/ > > > > > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches