From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83413C2D0E4 for ; Mon, 23 Nov 2020 09:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7CF1207FF for ; Mon, 23 Nov 2020 09:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Ipo/cMAQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbgKWJka (ORCPT ); Mon, 23 Nov 2020 04:40:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgKWJk3 (ORCPT ); Mon, 23 Nov 2020 04:40:29 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405CCC0613CF for ; Mon, 23 Nov 2020 01:40:29 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id h21so16579410wmb.2 for ; Mon, 23 Nov 2020 01:40:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tGsmN+GKaX7yYJkwfaBxmDkjMYGs2JFf+vI7xCtXl+c=; b=Ipo/cMAQ0WeveU8fNhd76pL0nqY6B7mRDA7/pjLLrJNoGJmMhgr1aq6rG3o8B90y4/ sUzKAyfnPd7J7x8yidEqCb0AWbt2/s2Q+woNHiFpy1RRG7T7vaSG1g0mC1N9K45omEzR piKmOEGFku9pwIdHhqBKR5OECjje61vFWp5Q6A/+USricHVkfcmue5w3Fcafhxq2W35C G3PK9IFe2uKJ6gsssS1lkZXJakVbyUPWb0n8QwNriS32nAkGyVMTf5Up3IoLO2wEkyMV MmjPi1dHY5BfyqjJdnht5K2/9aSaM7Zoj16dAls90pRW4tqpXzTyK64bHeQNUpwuql6A zRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tGsmN+GKaX7yYJkwfaBxmDkjMYGs2JFf+vI7xCtXl+c=; b=V6MWx7/x8KwgZsETrcNc/o8bdNHSYLRjJnzY7Zzg3jVIlpMQ5YpYZh8T+Y/eEeiBrR a8HmHqVLZEW2XQqCO+JQmm91N82of3L8ZRpba6ZC1Xi96viU+pmNU23tq/da0bxmWRCT zHs2uClaElwfZ8oQ5bVQ0QM5eCsVPnEZqe1GU5OeT2a5iRCsddW+CNnT5iiEhe/F5odN bi1A/3A7qvvvlWYDUH8UpypCVAbJENhUE+i6XSIjFQPII4nvPqG42OP5U48dSzr0Cl+9 pj7G/c/AMTEvXKJ55dVw8eWzZHw7AU4Cn3Yscmbety2QiXNEhkwLVdm+3SS25r2BHAI2 Y9QQ== X-Gm-Message-State: AOAM532kznZTzQc79mLG437OvHBpJxfjeIj6VM6zj8TKXpevlQWJrWlN oRy46ZjwFe7cUqiWBbwpZ9xZ1g== X-Google-Smtp-Source: ABdhPJxPGevhCi533Bj22BTAiWRzndS9Y8wMAOe97w1sXurxVvRQb1K1zDhAqE/t1baES6L7DkkmhQ== X-Received: by 2002:a1c:b487:: with SMTP id d129mr23614025wmf.38.1606124427984; Mon, 23 Nov 2020 01:40:27 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id e1sm15211664wmd.16.2020.11.23.01.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 01:40:27 -0800 (PST) Date: Mon, 23 Nov 2020 10:40:26 +0100 From: Jiri Pirko To: Edwin Peer Cc: Ido Schimmel , netdev , "David S . Miller" , Jakub Kicinski , jiri@nvidia.com, danieller@nvidia.com, andrew@lunn.ch, f.fainelli@gmail.com, mkubecek@suse.cz, mlxsw@nvidia.com, Ido Schimmel Subject: Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes Message-ID: <20201123094026.GF3055@nanopsycho.orion> References: <20201010154119.3537085-1-idosch@idosch.org> <20201010154119.3537085-2-idosch@idosch.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Nov 19, 2020 at 09:38:34PM CET, edwin.peer@broadcom.com wrote: >On Sat, Oct 10, 2020 at 3:54 PM Ido Schimmel wrote: > >> Add 'ETHTOOL_A_LINKMODES_LANES' attribute and expand 'struct >> ethtool_link_settings' with lanes field in order to implement a new >> lanes-selector that will enable the user to advertise a specific number >> of lanes as well. > >Why can't this be implied by port break-out configuration? For higher >speed signalling modes like PAM4, what's the difference between a >port with unused lanes vs the same port split into multiple logical >ports? In essence, the driver could then always choose the slowest There is a crucial difference. Split port is configured alwasy by user. Each split port has a devlink instace, netdevice associated with it. It is one level above the lanes. >signalling mode that utilizes all the available lanes. > >Regards, >Edwin Peer