From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B833C63697 for ; Mon, 23 Nov 2020 17:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5D932075A for ; Mon, 23 Nov 2020 17:30:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="GAwYE8Mf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390288AbgKWRaM (ORCPT ); Mon, 23 Nov 2020 12:30:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730399AbgKWRaL (ORCPT ); Mon, 23 Nov 2020 12:30:11 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC55BC0613CF; Mon, 23 Nov 2020 09:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+n9i9tL/XgZYnHTbCrgihSYQKPtV9aa5qeJPtl96feU=; b=GAwYE8MfGMdZHxTUgeLNypn3X jU/KEpqq2rNd7Owy/IEi9qASrORvEph9WgK6OWsy6c/Sc0UlFUgWLNp8IuKHCpgsVKT57HWMqiVrG JZDh9DDrJL3LJtiMPD80vK8gF2BdZuJNu3g4DAYUesrzoihNUshtGmrhw7kScs3bYKu/l3dFaygKF 7pD8exxWX8vmJ2OMR0AAnQhXmqJ5lAeH0q8lec1vEe5Sm7wicJzfyrhqpVkulFGLHGeIS6WuVQaYo gPcPINBvJCvvVyUAzrhN94oJPkJyz2gIJCxykbOV0GdPBVpmZyWKQbAEMMIOU2qyt5alLXBRWOUlF bt70fEn0Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35150) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khFfD-0006N9-US; Mon, 23 Nov 2020 17:30:07 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1khFfB-0006VA-5Q; Mon, 23 Nov 2020 17:30:05 +0000 Date: Mon, 23 Nov 2020 17:30:05 +0000 From: Russell King - ARM Linux admin To: Stefan Chulski Cc: "netdev@vger.kernel.org" , "thomas.petazzoni@bootlin.com" , "davem@davemloft.net" , Nadav Haklai , Yan Markman , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "mw@semihalf.com" , "andrew@lunn.ch" Subject: Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only Message-ID: <20201123173005.GY1551@shell.armlinux.org.uk> References: <1606143160-25589-1-git-send-email-stefanc@marvell.com> <20201123151049.GV1551@shell.armlinux.org.uk> <20201123153332.GW1551@shell.armlinux.org.uk> <20201123155148.GX1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Nov 23, 2020 at 04:03:00PM +0000, Stefan Chulski wrote: > > -----Original Message----- > > From: Russell King - ARM Linux admin > > Sent: Monday, November 23, 2020 5:52 PM > > To: Stefan Chulski > > Cc: netdev@vger.kernel.org; thomas.petazzoni@bootlin.com; > > davem@davemloft.net; Nadav Haklai ; Yan Markman > > ; linux-kernel@vger.kernel.org; kuba@kernel.org; > > mw@semihalf.com; andrew@lunn.ch > > Subject: Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports > > only > > > > On Mon, Nov 23, 2020 at 03:44:05PM +0000, Stefan Chulski wrote: > > > Yes, but this allocation exists also in current code. > > > From HW point of view(MAC and PPv2) maximum supported speed in CP110: > > > port 0 - 10G, port 1 - 2.5G, port 2 - 2.5G. > > > in CP115: port 0 - 10G, port 1 - 5G, port 2 - 2.5G. > > > > > > So this allocation looks correct at least for CP115. > > > Problem that we cannot reallocate FIFO during runtime, after specific speed > > negotiation. > > > > We could do much better. DT has a "max-speed" property for ethernet > > controllers. If we have that property, then I think we should use that to > > determine the initialisation time FIFO allocation. > > > > As I say, on Macchiatobin, the allocations we end up with are just crazy when > > you consider the port speeds that the hardware supports. > > Maybe that should be done as a follow-on patch - but I think it needs to be > > done. > > I agree with you. We can use "max-speed" for better FIFO allocations. > I plan to upstream more fixes from the "Marvell" devel branch then I can prepare this patch. > So you OK with this patch and then follow-on improvement? Yes - but I would like to see the commit description say that this results in no change the situation where all three ports are in use. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!