From: Sudeep Holla <sudeep.holla@arm.com>
To: netdev@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Ioana Radulescu <ruxandra.radulescu@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH] dpaa2-mac: select NET_DEVLINK to fix build
Date: Thu, 26 Nov 2020 14:09:33 +0000 [thread overview]
Message-ID: <20201126140933.1535197-1-sudeep.holla@arm.com> (raw)
When NET_DEVLINK is not selected, we get the following build error:
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:554: undefined reference to `devlink_trap_report'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:42: undefined reference to `devlink_info_driver_name_put'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:47: undefined reference to `devlink_info_version_running_put'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_register':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:199: undefined reference to `devlink_alloc'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:207: undefined reference to `devlink_register'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:216: undefined reference to `devlink_free'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_unregister':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:223: undefined reference to `devlink_unregister'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:224: undefined reference to `devlink_free'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_port_add':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:234: undefined reference to `devlink_port_attrs_set'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:236: undefined reference to `devlink_port_register'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:240: undefined reference to `devlink_port_type_eth_set'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_port_del':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:249: undefined reference to `devlink_port_type_clear'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:250: undefined reference to `devlink_port_unregister'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_traps_register':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:273: undefined reference to `devlink_trap_groups_register'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:280: undefined reference to `devlink_traps_register'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:290: undefined reference to `devlink_trap_groups_unregister'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_traps_unregister':
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:303: undefined reference to `devlink_traps_unregister'
ld: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c:305: undefined reference to `devlink_trap_groups_unregister'
Commit f6b19b354d50 ("net: devlink: select NET_DEVLINK from drivers")
selected NET_DEVLINK from several drivers and rely on the functions
being there.
Replicate the same for FSL_DPAA2_ETH.
Cc: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
index cfd369cf4c8c..a86f9ebcf63b 100644
--- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
@@ -4,6 +4,7 @@ config FSL_DPAA2_ETH
depends on FSL_MC_BUS && FSL_MC_DPIO
select PHYLINK
select PCS_LYNX
+ select NET_DEVLINK
help
This is the DPAA2 Ethernet driver supporting Freescale SoCs
with DPAA2 (DataPath Acceleration Architecture v2).
--
2.25.1
next reply other threads:[~2020-11-26 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 14:09 Sudeep Holla [this message]
2020-11-26 15:54 ` [PATCH] dpaa2-mac: select NET_DEVLINK to fix build Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126140933.1535197-1-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox