From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: Peter Vollmer <peter.vollmer@gmail.com>,
Network Development <netdev@vger.kernel.org>
Subject: Re: dsa/mv88e6xxx: leaking packets on MV88E6341 switch
Date: Thu, 26 Nov 2020 23:23:59 +0100 [thread overview]
Message-ID: <20201126222359.GO2075216@lunn.ch> (raw)
In-Reply-To: <87y2in94o7.fsf@waldekranz.com>
> > I tested setting .tag_protocol=DSA_TAG_PROTO_DSA for the 6341 switch
> > instead, resulting in a register setting of 04 Port control for port 5
> > = 0x053f (i.e. EgressMode=Unmodified mode, frames are transmitted
> > unmodified), which looks correct to me. It does not fix the above
> > problem, but the change seems to make sense anyhow. Should I send a
> > patch ?
>
> This is not up to me, but my guess is that Andrew would like a patch,
> yes. On 6390X, I know for a fact that setting the EgressMode to 3 does
> indeed produce the behavior that was supported in older devices (like
> the 6352), but there is no reason not to change it to regular DSA.
I already said to Tobias, i had problems getting the 6390 working, and
this was one of the things i changed. I don't think i ever undid this
specific change, to see how critical it is. But relying on
undocumented behaviour is not nice.
EDSA used to have the advantages that tcpdump understood it. But
thanks to work Florian and Vivien did, tcpdump can now decode DSA just
as well as EDSA.
So please do submit a patch.
Andrew
next prev parent reply other threads:[~2020-11-26 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 10:09 dsa/mv88e6xxx: leaking packets on MV88E6341 switch Peter Vollmer
2020-09-30 10:28 ` Vladimir Oltean
2020-09-30 11:57 ` Peter Vollmer
2020-09-30 19:19 ` Andrew Lunn
2020-10-01 6:21 ` Peter Vollmer
2020-11-25 14:09 ` Peter Vollmer
2020-11-26 21:41 ` Tobias Waldekranz
2020-11-26 22:23 ` Andrew Lunn [this message]
2020-12-01 9:00 ` Peter Vollmer
2020-12-01 13:58 ` Andrew Lunn
2020-12-01 8:49 ` Peter Vollmer
2020-12-01 12:29 ` Tobias Waldekranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126222359.GO2075216@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=peter.vollmer@gmail.com \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).