From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>
Subject: Re: [PATCH net] net: dsa: reference count the host mdb addresses
Date: Sat, 28 Nov 2020 00:27:18 +0000 [thread overview]
Message-ID: <20201128002717.buvgy3unu6af5ejj@skbuf> (raw)
In-Reply-To: <87im9q8i99.fsf@waldekranz.com>
On Sat, Nov 28, 2020 at 12:58:10AM +0100, Tobias Waldekranz wrote:
> That sounds like a good idea. We have run into another issue with the
> MDB that maybe could be worked into this changeset. This is what we have
> observed on 4.19, but from looking at the source it does not look like
> anything has changed with respect to this issue.
>
> The DSA driver handles the addition/removal of router ports by
> enabling/disabling multicast flooding to the port in question. On
> mv88e6xxx at least, this is only part of the solution. It only takes
> care of the unregistered multicast. You also have to iterate through all
> _registered_ groups and add the port to the destination vector.
And this observation is based on what? Based on this paragraph from RFC4541?
2.1.2. Data Forwarding Rules
1) Packets with a destination IP address outside 224.0.0.X which are
not IGMP should be forwarded according to group-based port
membership tables and must also be forwarded on router ports.
Let me ask you a different question. Why would DSA be in charge of
updating the MDB records, and not the bridge? Or why DSA and not the end
driver? Ignore my patch. I'm just trying to understand what you're
saying. Why precisely DSA, the mid layer? I don't know, this is new
information to me, I'm still digesting it.
next prev parent reply other threads:[~2020-11-28 0:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 21:27 [PATCH net] net: dsa: reference count the host mdb addresses Vladimir Oltean
2020-10-19 23:55 ` Jakub Kicinski
2020-10-20 0:07 ` Andrew Lunn
2020-10-20 0:13 ` Jakub Kicinski
2020-10-20 0:06 ` Andrew Lunn
2020-10-20 0:28 ` Vladimir Oltean
2020-10-20 2:11 ` Florian Fainelli
2020-11-27 21:41 ` Vladimir Oltean
2020-11-27 23:58 ` Tobias Waldekranz
2020-11-28 0:27 ` Vladimir Oltean [this message]
2020-11-28 9:34 ` Tobias Waldekranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128002717.buvgy3unu6af5ejj@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox