public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
	daniel@iogearbox.net, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/7] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier
Date: Sat, 28 Nov 2020 17:56:28 -0800	[thread overview]
Message-ID: <20201129015628.4jxmeesxfynowpcn@ast-mbp> (raw)
In-Reply-To: <20201121024616.1588175-2-andrii@kernel.org>

On Fri, Nov 20, 2020 at 06:46:10PM -0800, Andrii Nakryiko wrote:
>  
> @@ -52,12 +53,19 @@ struct bpf_reg_state {
>  		 */
>  		struct bpf_map *map_ptr;
>  
> -		u32 btf_id; /* for PTR_TO_BTF_ID */
> +		/* for PTR_TO_BTF_ID */
> +		struct {
> +			struct btf *btf;
> +			u32 btf_id;
> +		};

bpf_reg_state is the main structure contributing to the verifier memory consumption.
Is it possible to do the tracking without growing it?

>  
>  		u32 mem_size; /* for PTR_TO_MEM | PTR_TO_MEM_OR_NULL */
>  
>  		/* Max size from any of the above. */
> -		unsigned long raw;
> +		struct {
> +			unsigned long raw1;
> +			unsigned long raw2;
> +		} raw;

  reply	other threads:[~2020-11-29  1:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-21  2:46 [PATCH bpf-next 0/7] Add kernel modules support for tracing BPF program attachments Andrii Nakryiko
2020-11-21  2:46 ` [PATCH bpf-next 1/7] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier Andrii Nakryiko
2020-11-29  1:56   ` Alexei Starovoitov [this message]
2020-11-30 23:04     ` Andrii Nakryiko
2020-12-01  1:18       ` Alexei Starovoitov
2020-11-21  2:46 ` [PATCH bpf-next 2/7] bpf: allow to specify kernel module BTFs when attaching BPF programs Andrii Nakryiko
2020-11-21  2:46 ` [PATCH bpf-next 3/7] libbpf: factor out low-level BPF program loading helper Andrii Nakryiko
2020-11-21  2:46 ` [PATCH bpf-next 4/7] libbpf: support attachment of BPF tracing programs to kernel modules Andrii Nakryiko
2020-11-21  2:46 ` [PATCH bpf-next 5/7] selftests/bpf: add tp_btf CO-RE reloc test for modules Andrii Nakryiko
2020-11-29  1:59   ` Alexei Starovoitov
2020-11-30 22:52     ` Andrii Nakryiko
2020-11-30 22:55       ` Alexei Starovoitov
2020-11-21  2:46 ` [PATCH bpf-next 6/7] selftests/bpf: make BPF sidecar traceable function global Andrii Nakryiko
2020-11-21  2:46 ` [PATCH bpf-next 7/7] selftests/bpf: add fentry/fexit/fmod_ret selftest for kernel module Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129015628.4jxmeesxfynowpcn@ast-mbp \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox