From: Andrew Lunn <andrew@lunn.ch>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ryan Barnett <ryan.barnett@rockwellcollins.com>,
Conrad Ratschan <conrad.ratschan@rockwellcollins.com>,
Hugo Cornelis <hugo.cornelis@essensium.com>,
Arnout Vandecappelle <arnout.vandecappelle@essensium.com>
Subject: Re: [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission
Date: Sun, 29 Nov 2020 17:56:27 +0100 [thread overview]
Message-ID: <20201129165627.GA2234159@lunn.ch> (raw)
In-Reply-To: <20201129102400.157786-1-jean.pihet@newoldbits.com>
On Sun, Nov 29, 2020 at 11:23:59AM +0100, Jean Pihet wrote:
> Some ethernet controllers (e.g. TI CPSW) pad the frames to a minimum
> of 64 bytes before the FCS is appended. This causes an issue with the
> KSZ tail tag which could not be the last byte before the FCS.
> Solve this by padding the frame to 64 bytes minus the tail tag size,
> before the tail tag is added and the frame is passed for transmission.
Hi Jean
what tree is this based on? Have you seen
commit 88fda8eefd9a7a7175bf4dad1d02cc0840581111
Author: Christian Eggers <ceggers@arri.de>
Date: Sun Nov 1 21:16:10 2020 +0200
net: dsa: tag_ksz: don't allocate additional memory for padding/tagging
The caller (dsa_slave_xmit) guarantees that the frame length is at least
ETH_ZLEN and that enough memory for tail tagging is available.
next prev parent reply other threads:[~2020-11-29 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 10:23 [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission Jean Pihet
2020-11-29 10:24 ` [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface Jean Pihet
2020-11-29 12:51 ` kernel test robot
2020-11-29 12:51 ` [RFC PATCH] net: dsa: ksz8795: ksz8795_adjust_link() can be static kernel test robot
2020-11-29 13:17 ` [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface kernel test robot
2020-11-29 17:07 ` Andrew Lunn
2020-11-29 16:56 ` Andrew Lunn [this message]
2020-11-29 19:34 ` [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission Jean Pihet
2020-11-29 19:38 ` Andrew Lunn
2020-11-29 19:48 ` Jean Pihet
2020-11-29 16:57 ` Andrew Lunn
2020-11-29 19:35 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129165627.GA2234159@lunn.ch \
--to=andrew@lunn.ch \
--cc=arnout.vandecappelle@essensium.com \
--cc=conrad.ratschan@rockwellcollins.com \
--cc=hugo.cornelis@essensium.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryan.barnett@rockwellcollins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).