From: Andrew Lunn <andrew@lunn.ch>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ryan Barnett <ryan.barnett@rockwellcollins.com>,
Conrad Ratschan <conrad.ratschan@rockwellcollins.com>,
Hugo Cornelis <hugo.cornelis@essensium.com>,
Arnout Vandecappelle <arnout.vandecappelle@essensium.com>
Subject: Re: [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface
Date: Sun, 29 Nov 2020 18:07:22 +0100 [thread overview]
Message-ID: <20201129170722.GC2234159@lunn.ch> (raw)
In-Reply-To: <20201129102400.157786-2-jean.pihet@newoldbits.com>
On Sun, Nov 29, 2020 at 11:24:00AM +0100, Jean Pihet wrote:
> Add support for RGMII in 100 and 1000 Mbps.
>
> Adjust the CPU port based on the host interface settings: interface
> MII type, speed, duplex.
Please could you add some extra information here why this is needed. I
suspect you have back to back PHYs on the CPU port?
> +void ksz8795_adjust_link(struct dsa_switch *ds, int port,
> + struct phy_device *phydev)
> +{
> + struct ksz_device *dev = ds->priv;
> + struct ksz_port *p = &dev->ports[port];
> +
> + /* Adjust the link interface mode and speed for the CPU port */
> + if (port == dev->cpu_port)
dsa_is_cpu_port(ds, port)
Andrew
next prev parent reply other threads:[~2020-11-29 17:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 10:23 [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission Jean Pihet
2020-11-29 10:24 ` [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface Jean Pihet
2020-11-29 12:51 ` kernel test robot
2020-11-29 12:51 ` [RFC PATCH] net: dsa: ksz8795: ksz8795_adjust_link() can be static kernel test robot
2020-11-29 13:17 ` [PATCH 2/2] net: dsa: ksz8795: adjust CPU link to host interface kernel test robot
2020-11-29 17:07 ` Andrew Lunn [this message]
2020-11-29 16:56 ` [PATCH 1/2] net: dsa: ksz: pad frame to 64 bytes for transmission Andrew Lunn
2020-11-29 19:34 ` Jean Pihet
2020-11-29 19:38 ` Andrew Lunn
2020-11-29 19:48 ` Jean Pihet
2020-11-29 16:57 ` Andrew Lunn
2020-11-29 19:35 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129170722.GC2234159@lunn.ch \
--to=andrew@lunn.ch \
--cc=arnout.vandecappelle@essensium.com \
--cc=conrad.ratschan@rockwellcollins.com \
--cc=hugo.cornelis@essensium.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryan.barnett@rockwellcollins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).