From: Andrew Lunn <andrew@lunn.ch>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Ishizaki Kou <kou.ishizaki@toshiba.co.jp>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Utz Bacher <utz.bacher@de.ibm.com>,
Jens Osterkamp <Jens.Osterkamp@de.ibm.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 7/8] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters
Date: Sun, 29 Nov 2020 20:08:23 +0100 [thread overview]
Message-ID: <20201129190823.GN2234159@lunn.ch> (raw)
In-Reply-To: <20201126133853.3213268-8-lee.jones@linaro.org>
On Thu, Nov 26, 2020 at 01:38:52PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter or member 'hwdescr' not described in 'spider_net_get_descr_status'
> drivers/net/ethernet/toshiba/spider_net.c:263: warning: Excess function parameter 'descr' description in 'spider_net_get_descr_status'
> drivers/net/ethernet/toshiba/spider_net.c:554: warning: Function parameter or member 'netdev' not described in 'spider_net_get_multicast_hash'
> drivers/net/ethernet/toshiba/spider_net.c:902: warning: Function parameter or member 't' not described in 'spider_net_cleanup_tx_ring'
> drivers/net/ethernet/toshiba/spider_net.c:902: warning: Excess function parameter 'card' description in 'spider_net_cleanup_tx_ring'
> drivers/net/ethernet/toshiba/spider_net.c:1074: warning: Function parameter or member 'card' not described in 'spider_net_resync_head_ptr'
> drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Function parameter or member 'napi' not described in 'spider_net_poll'
> drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Excess function parameter 'netdev' description in 'spider_net_poll'
> drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Function parameter or member 'p' not described in 'spider_net_set_mac'
> drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Excess function parameter 'ptr' description in 'spider_net_set_mac'
> drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg1' not described in 'spider_net_handle_error_irq'
> drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg2' not described in 'spider_net_handle_error_irq'
> drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Function parameter or member 't' not described in 'spider_net_link_phy'
> drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Excess function parameter 'data' description in 'spider_net_link_phy'
> drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Function parameter or member 'work' not described in 'spider_net_tx_timeout_task'
> drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Excess function parameter 'data' description in 'spider_net_tx_timeout_task'
> drivers/net/ethernet/toshiba/spider_net.c:2182: warning: Function parameter or member 'txqueue' not described in 'spider_net_tx_timeout'
>
> Cc: Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Utz Bacher <utz.bacher@de.ibm.com>
> Cc: Jens Osterkamp <Jens.Osterkamp@de.ibm.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-11-29 19:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 13:38 [PATCH 0/8] Rid W=1 warnings in Net Lee Jones
2020-11-26 13:38 ` [PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Lee Jones
2020-11-29 18:33 ` Andrew Lunn
2020-11-30 8:59 ` Lee Jones
2020-11-26 13:38 ` [PATCH 2/8] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Lee Jones
2020-11-29 18:34 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 3/8] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Lee Jones
2020-11-29 18:35 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 4/8] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Lee Jones
2020-11-29 18:37 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 5/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Lee Jones
2020-11-29 18:43 ` Andrew Lunn
2020-11-30 9:04 ` Lee Jones
2020-11-26 13:38 ` [PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: " Lee Jones
2020-11-29 18:45 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 7/8] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Lee Jones
2020-11-29 19:08 ` Andrew Lunn [this message]
2020-11-26 13:38 ` [PATCH 8/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Lee Jones
2020-11-29 19:10 ` Andrew Lunn
2020-11-30 8:59 ` Lee Jones
2020-11-27 17:39 ` [PATCH 0/8] Rid W=1 warnings in Net Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129190823.GN2234159@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jens.Osterkamp@de.ibm.com \
--cc=davem@davemloft.net \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=utz.bacher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).