From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC6BC5519F for ; Mon, 30 Nov 2020 09:00:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDB9F2074A for ; Mon, 30 Nov 2020 09:00:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rJvWgeMP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727872AbgK3JAN (ORCPT ); Mon, 30 Nov 2020 04:00:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727721AbgK3JAN (ORCPT ); Mon, 30 Nov 2020 04:00:13 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9DD1C0613CF for ; Mon, 30 Nov 2020 00:59:30 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id k10so11052771wmi.3 for ; Mon, 30 Nov 2020 00:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=3hM+phFbSccuPNXURtLkQPcsGT4rPyJ0on20dI+C1Qw=; b=rJvWgeMPDJjEKJNRCC8yQz0N0Ut2wK5L+xQwBVUvMytQP/WgEdBTMzV4rvh9KIaYjP E2NAJTqgwzKngo5FnKjNOv2x+y1F4WtHr0xEotVzgN2DGYPvprnM0xbdpJQ5PvzbY6R8 ejRORUmiHFPPrUWZgGXjPpwaS4rICehg3rp+YmaTEB7s4pchLKW91b3TgQK6CRHakjQb XT+qkq4ijcGBvUbnNbgOcEHGvybYPYr0wmR1GdFoRWOmqKSTP3yxqRJ+cQ6wB5+PwDy9 CpfGwHnt8SQYDTyxk74Xsu6o4gjZcZFhUYSdBE1ZwkHZAl9PxnOG3edaGJct/cHpNXUT BilA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3hM+phFbSccuPNXURtLkQPcsGT4rPyJ0on20dI+C1Qw=; b=B4+RZVH2xk3PrywONBIeWjTn/hQ8vSuHK53r+td9zxakI5ZZh83+/Yuv2x5sf0fa/y +WCYpNUKrxItlzEcx0IVfgcXBbtWt9065STMDQnbPktDrrAr/X91eedtp7+uCq2YP3Ow ga7ctd6nq3tKmnkIjConJHBP7Nm6QWzxC/PDe8e0dQl0V4hvYw9JQyD27wkw1L3uIdVZ nLiJtVDC9BcbKtkPfa8uGPyl84j7U9jKYHAPq1cbndA7Cy/jwrE+//MaHbPZcgdkQ8Sf kIZvc8KH/pP7hGEgKOXaMolU/cT4CugU20yWHaABczmlyqagNCkSm4oDQb+Suqljb1qH 8V5Q== X-Gm-Message-State: AOAM530Go9R0jzVyph0MgVVhf0/c+0snHOTT7UjFV4oKtxqPmexU1vkG t9sNBHanyR2lsYiSpKa8bKZuzw== X-Google-Smtp-Source: ABdhPJw+Kc4lxyw2Sqwg6q/29/xhcLtgRtfpGiTtJszcuqv4nSBWi2fAXTXpo7wCEQsrS26cNR02Xw== X-Received: by 2002:a1c:f617:: with SMTP id w23mr22239554wmc.52.1606726769505; Mon, 30 Nov 2020 00:59:29 -0800 (PST) Received: from dell ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id f18sm26960482wru.42.2020.11.30.00.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 00:59:28 -0800 (PST) Date: Mon, 30 Nov 2020 08:59:27 +0000 From: Lee Jones To: Andrew Lunn Cc: linux-kernel@vger.kernel.org, Nicolas Pitre , "David S. Miller" , Jakub Kicinski , Erik Stahlman , Peter Cammaert , Daris A Nevil , Russell King , netdev@vger.kernel.org Subject: Re: [PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Message-ID: <20201130085927.GB4801@dell> References: <20201126133853.3213268-1-lee.jones@linaro.org> <20201126133853.3213268-2-lee.jones@linaro.org> <20201129183309.GH2234159@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201129183309.GH2234159@lunn.ch> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 29 Nov 2020, Andrew Lunn wrote: > On Thu, Nov 26, 2020 at 01:38:46PM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio' > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio' > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio' > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio' > > drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio' > > > > Cc: Nicolas Pitre > > Cc: "David S. Miller" > > Cc: Jakub Kicinski > > Cc: Erik Stahlman > > Cc: Peter Cammaert > > Cc: Daris A Nevil > > Cc: Russell King > > Cc: netdev@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/net/ethernet/smsc/smc91x.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c > > index 56c36798cb111..3b90dc065ff2d 100644 > > --- a/drivers/net/ethernet/smsc/smc91x.c > > +++ b/drivers/net/ethernet/smsc/smc91x.c > > @@ -2191,7 +2191,7 @@ static const struct of_device_id smc91x_match[] = { > > MODULE_DEVICE_TABLE(of, smc91x_match); > > > > #if defined(CONFIG_GPIOLIB) > > -/** > > +/* > > * of_try_set_control_gpio - configure a gpio if it exists > > * @dev: net device > > * @desc: where to store the GPIO descriptor, if it exists > > Hi Lee > > This is the wrong fix. The name of the function in the documentation > should be corrected. The rest looks correct. Yes, you're right. Will fix. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog