Re: Correct usage of dev_base_lock in 2020

Eric Dumazet
2020-11-30T22:21:23Z

On Mon, Nov 30, 2020 at 10:53 PM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> On Mon, Nov 30, 2020 at 10:46:00PM +0100, Eric Dumazet wrote:
> > You can not use dev_base_lock() or RCU and call an ndo_get_stats64()
> > that could sleep.
> >
> > You can not for example start changing bonding, since bond_get_stats()
> > could be called from non-sleepable context (net/core/net-procfs.c)
> >
> > I am still referring to your patch adding :
> >
> > + if (!rtnl_locked)
> > + rtnl_lock();
> >
> > This is all I said.
>
> Ah, ok, well I didn't show you all the patches, did I?

Have you sent them during Thanksgiving perhaps ?

I suggest you follow normal submission process, sending patch series
rather than inlining multiple patches in one email, this is becoming
hard to follow.