Re: [PATCH] ptp: Add clock driver for the OpenCompute TimeCard.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2356 bytes --]

Hi Jonathan,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on ipvs/master net-next/master linus/master v5.10-rc6 next-20201201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jonathan-Lemon/ptp-Add-clock-driver-for-the-OpenCompute-TimeCard/20201202-045520
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 14483cbf040fcb38113497161088a1ce8ce5d713
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/212c31abce553dfb3146a24086b8a50046097f0d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jonathan-Lemon/ptp-Add-clock-driver-for-the-OpenCompute-TimeCard/20201202-045520
        git checkout 212c31abce553dfb3146a24086b8a50046097f0d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_remove':
>> drivers/ptp/ptp_ocp.c:374:2: error: implicit declaration of function 'pci_iounmap'; did you mean 'pcim_iounmap'? [-Werror=implicit-function-declaration]
     374 |  pci_iounmap(pdev, bp->base);
         |  ^~~~~~~~~~~
         |  pcim_iounmap
   cc1: some warnings being treated as errors

vim +374 drivers/ptp/ptp_ocp.c

   367	
   368	static void
   369	ptp_ocp_remove(struct pci_dev *pdev)
   370	{
   371		struct ptp_ocp *bp = pci_get_drvdata(pdev);
   372	
   373		ptp_clock_unregister(bp->ptp);
 > 374		pci_iounmap(pdev, bp->base);
   375		pci_release_regions(pdev);
   376		pci_disable_device(pdev);
   377		pci_set_drvdata(pdev, NULL);
   378		kfree(bp);
   379	}
   380	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53576 bytes --]