From: kernel test robot <lkp@intel.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
daniel@iogearbox.net
Cc: kbuild-all@lists.01.org, andrii@kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v5 bpf-next 09/14] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier
Date: Thu, 3 Dec 2020 14:32:47 +0800 [thread overview]
Message-ID: <202012031414.Zg9APo76-lkp@intel.com> (raw)
In-Reply-To: <20201203035204.1411380-10-andrii@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]
Hi Andrii,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-randconfig-s002-20201203 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-179-ga00755aa-dirty
# https://github.com/0day-ci/linux/commit/c0eabf99f8312c12d4c210628360d28bbf915a91
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andrii-Nakryiko/Support-BTF-powered-BPF-tracing-programs-for-kernel-modules/20201203-115515
git checkout c0eabf99f8312c12d4c210628360d28bbf915a91
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
ld: kernel/bpf/core.o: in function `bpf_prog_free':
>> kernel/bpf/core.c:2155: undefined reference to `btf_put'
vim +2155 kernel/bpf/core.c
2146
2147 /* Free internal BPF program */
2148 void bpf_prog_free(struct bpf_prog *fp)
2149 {
2150 struct bpf_prog_aux *aux = fp->aux;
2151
2152 if (aux->dst_prog)
2153 bpf_prog_put(aux->dst_prog);
2154 if (aux->attach_btf)
> 2155 btf_put(aux->attach_btf);
2156 INIT_WORK(&aux->work, bpf_prog_free_deferred);
2157 schedule_work(&aux->work);
2158 }
2159 EXPORT_SYMBOL_GPL(bpf_prog_free);
2160
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29583 bytes --]
next prev parent reply other threads:[~2020-12-03 6:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:51 [PATCH v5 bpf-next 00/14] Support BTF-powered BPF tracing programs for kernel modules Andrii Nakryiko
2020-12-03 3:51 ` [PATCH v5 bpf-next 01/14] bpf: fix bpf_put_raw_tracepoint()'s use of __module_address() Andrii Nakryiko
2020-12-03 4:36 ` John Fastabend
2020-12-03 3:51 ` [PATCH v5 bpf-next 02/14] bpf: keep module's btf_data_size intact after load Andrii Nakryiko
2020-12-03 3:51 ` [PATCH v5 bpf-next 03/14] libbpf: add internal helper to load BTF data by FD Andrii Nakryiko
2020-12-03 4:51 ` John Fastabend
2020-12-03 3:51 ` [PATCH v5 bpf-next 04/14] libbpf: refactor CO-RE relocs to not assume a single BTF object Andrii Nakryiko
2020-12-03 5:11 ` John Fastabend
2020-12-03 3:51 ` [PATCH v5 bpf-next 05/14] libbpf: add kernel module BTF support for CO-RE relocations Andrii Nakryiko
2020-12-03 5:30 ` John Fastabend
2020-12-03 5:38 ` Andrii Nakryiko
2020-12-03 3:51 ` [PATCH v5 bpf-next 06/14] selftests/bpf: add bpf_testmod kernel module for testing Andrii Nakryiko
2020-12-03 3:51 ` [PATCH v5 bpf-next 07/14] selftests/bpf: add support for marking sub-tests as skipped Andrii Nakryiko
2020-12-03 3:51 ` [PATCH v5 bpf-next 08/14] selftests/bpf: add CO-RE relocs selftest relying on kernel module BTF Andrii Nakryiko
2020-12-03 3:51 ` [PATCH v5 bpf-next 09/14] bpf: remove hard-coded btf_vmlinux assumption from BPF verifier Andrii Nakryiko
2020-12-03 6:13 ` kernel test robot
2020-12-03 6:32 ` kernel test robot [this message]
2020-12-03 3:52 ` [PATCH v5 bpf-next 10/14] bpf: allow to specify kernel module BTFs when attaching BPF programs Andrii Nakryiko
2020-12-03 3:52 ` [PATCH v5 bpf-next 11/14] libbpf: factor out low-level BPF program loading helper Andrii Nakryiko
2020-12-03 3:52 ` [PATCH v5 bpf-next 12/14] libbpf: support attachment of BPF tracing programs to kernel modules Andrii Nakryiko
2020-12-03 3:52 ` [PATCH v5 bpf-next 13/14] selftests/bpf: add tp_btf CO-RE reloc test for modules Andrii Nakryiko
2020-12-03 3:52 ` [PATCH v5 bpf-next 14/14] selftests/bpf: add fentry/fexit/fmod_ret selftest for kernel module Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012031414.Zg9APo76-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kbuild-all@lists.01.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).