From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
"Allan W . Nielsen" <allan.nielsen@microchip.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Steen Hegelund <steen.hegelund@microchip.com>
Subject: Re: [PATCH v2 net] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context
Date: Fri, 4 Dec 2020 18:25:45 +0000 [thread overview]
Message-ID: <20201204182544.ddgoqvzp42s4rncp@skbuf> (raw)
In-Reply-To: <20201204100021.0b026725@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
On Fri, Dec 04, 2020 at 10:00:21AM -0800, Jakub Kicinski wrote:
> Does get_device really protect you from unbind? I thought it only
> protects you from .release being called, IOW freeing struct device
> memory..
>
> More usual way of handling this would be allocating your own workqueue
> and flushing that wq at the right point.
>
> > drivers/net/ethernet/mscc/ocelot_net.c | 83 +++++++++++++++++++++++++-
> > 1 file changed, 80 insertions(+), 3 deletions(-)
>
> This is a little large for a rc7 fix :S
If you like v1 more, you can apply v1.
prev parent reply other threads:[~2020-12-04 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 17:51 [PATCH v2 net] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context Vladimir Oltean
2020-12-04 18:00 ` Jakub Kicinski
2020-12-04 18:12 ` Vladimir Oltean
2020-12-04 18:15 ` Alexandre Belloni
2020-12-04 18:55 ` Jakub Kicinski
2020-12-04 19:23 ` Vladimir Oltean
2020-12-05 0:41 ` Jakub Kicinski
2020-12-04 19:24 ` Jakub Kicinski
2020-12-04 19:26 ` Alexandre Belloni
2020-12-04 18:25 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204182544.ddgoqvzp42s4rncp@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox