From: Stephen Suryaputra <ssuryaextr@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] vrf: packets with lladdr src needs dst at input with orig_iif when needs strict
Date: Fri, 4 Dec 2020 19:22:27 -0500 [thread overview]
Message-ID: <20201205002227.GA8699@ICIPI.localdomain> (raw)
In-Reply-To: <20201204153748.00715355@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
On Fri, Dec 04, 2020 at 03:37:48PM -0800, Jakub Kicinski wrote:
> On Fri, 4 Dec 2020 09:32:04 -0700 David Ahern wrote:
> > On 12/3/20 8:06 PM, Stephen Suryaputra wrote:
> > > Depending on the order of the routes to fe80::/64 are installed on the
> > > VRF table, the NS for the source link-local address of the originator
> > > might be sent to the wrong interface.
> > >
> > > This patch ensures that packets with link-local addr source is doing a
> > > lookup with the orig_iif when the destination addr indicates that it
> > > is strict.
> > >
> > > Add the reproducer as a use case in self test script fcnal-test.sh.
> > >
> > > Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
> > > ---
> > > drivers/net/vrf.c | 10 ++-
> > > tools/testing/selftests/net/fcnal-test.sh | 95 +++++++++++++++++++++++
> > > 2 files changed, 103 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: David Ahern <dsahern@kernel.org>
>
> Should I put something like:
>
> Fixes: b4869aa2f881 ("net: vrf: ipv6 support for local traffic to local addresses")
>
> on this?
I was conflicted when I was about to put Fixes tag on this patch because
it could either be b4869aa2f881 that you mentioned above, or 6f12fa7755301
("vrf: mark skb for multicast or link-local as enslaved to VRF"). So, I
decided not to put it, but may be I should so that this is qualified to
be queued to stable?
Thanks,
Stephen.
next prev parent reply other threads:[~2020-12-05 0:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 3:06 [PATCH net] vrf: packets with lladdr src needs dst at input with orig_iif when needs strict Stephen Suryaputra
2020-12-04 16:32 ` David Ahern
2020-12-04 23:37 ` Jakub Kicinski
2020-12-05 0:22 ` Stephen Suryaputra [this message]
2020-12-05 21:49 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205002227.GA8699@ICIPI.localdomain \
--to=ssuryaextr@gmail.com \
--cc=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).