From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCD0C1B087 for ; Mon, 7 Dec 2020 16:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 937FB238E8 for ; Mon, 7 Dec 2020 16:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728025AbgLGQf7 (ORCPT ); Mon, 7 Dec 2020 11:35:59 -0500 Received: from m43-15.mailgun.net ([69.72.43.15]:23216 "EHLO m43-15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728017AbgLGQf6 (ORCPT ); Mon, 7 Dec 2020 11:35:58 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1607358938; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=IW9DTF4PmF8ZmkQKPvCQah+cT5wir5KBEaelBBw/+SA=; b=mGgYsZBm1SNKmrE8E/QvoV4boOXN47ICyoEV/na/UKyXvCEDMQi0Qi+2FP0CtK/0MGdX8zNQ yc8Q4RitJkzEqSLQ0Fv3kb34rLjVppjs5NaCbMq1xzFh9/i2oT8ux4Abk+egcW7JU50v5hSL EPPjAjms2GAPCbHRManjMMcl8r4= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5fce59b6ca03b14965ed328e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 07 Dec 2020 16:35:02 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id ABA94C43461; Mon, 7 Dec 2020 16:35:02 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B5B17C433ED; Mon, 7 Dec 2020 16:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B5B17C433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] rtw88: coex: fix missing unitialization of variable 'interval' From: Kalle Valo In-Reply-To: <20201203175142.1071738-1-colin.king@canonical.com> References: <20201203175142.1071738-1-colin.king@canonical.com> To: Colin King Cc: Yan-Hsuan Chuang , "David S . Miller" , Jakub Kicinski , Ping-Ke Shih , Ching-Te Ku , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201207163502.ABA94C43461@smtp.codeaurora.org> Date: Mon, 7 Dec 2020 16:35:02 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Colin King wrote: > From: Colin Ian King > > Currently the variable 'interval' is not initialized and is only set > to 1 when oex_stat->bt_418_hid_existi is true. Fix this by inintializing > variable interval to 0 (which I'm assuming is the intended default). > > Addresses-Coverity: ("Uninitalized scalar variable") > Fixes: 5b2e9a35e456 ("rtw88: coex: add feature to enhance HID coexistence performance") > Signed-off-by: Colin Ian King > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. 88c15a6fbd94 rtw88: coex: fix missing unitialization of variable 'interval' -- https://patchwork.kernel.org/project/linux-wireless/patch/20201203175142.1071738-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches