From: Bjorn Helgaas <helgaas@kernel.org>
To: Puranjay Mohan <puranjay12@gmail.com>
Cc: siva.kallam@broadcom.com, prashant@broadcom.com,
mchan@broadcom.com, kuba@kernel.org, netdev@vger.kernel.org,
bjorn@helgaas.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH] drivers: broadcom: save return value of pci_find_capability() in u8
Date: Mon, 7 Dec 2020 17:00:34 -0600 [thread overview]
Message-ID: <20201207230034.GA2298434@bjorn-Precision-5520> (raw)
In-Reply-To: <20201206201033.21823-1-puranjay12@gmail.com>
On Mon, Dec 07, 2020 at 01:40:33AM +0530, Puranjay Mohan wrote:
> Callers of pci_find_capability() should save the return value in u8.
> change the type of pcix_cap from int to u8, to match the specification.
>
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> ---
> drivers/net/ethernet/broadcom/tg3.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h
> index 1000c894064f..f1781d2dce0b 100644
> --- a/drivers/net/ethernet/broadcom/tg3.h
> +++ b/drivers/net/ethernet/broadcom/tg3.h
> @@ -3268,7 +3268,7 @@ struct tg3 {
>
> int pci_fn;
> int msi_cap;
> - int pcix_cap;
> + u8 pcix_cap;
msi_cap is also a u8.
But I don't think it's worth changing either of these unless we take a
broader look and see whether they're needed at all.
msi_cap is used to restore the MSI enable bit after a highly
device-specific reset.
pcix_cap is used for some PCI-X configuration that really should be
done via pcix_set_mmrbc() and possibly some sort of quirk for
PCI_X_CMD_MAX_SPLIT.
But that's all pretty messy and I doubt it's worth doing it at this
point, since PCI-X is pretty much ancient history.
> int pcie_readrq;
>
> struct mii_bus *mdio_bus;
> --
> 2.27.0
>
prev parent reply other threads:[~2020-12-07 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 20:10 [PATCH] drivers: broadcom: save return value of pci_find_capability() in u8 Puranjay Mohan
2020-12-07 23:00 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207230034.GA2298434@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bjorn@helgaas.com \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=puranjay12@gmail.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox