* [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()
@ 2020-12-08 13:56 Zheng Yongjun
2020-12-08 19:19 ` Jakub Kicinski
2020-12-09 0:25 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-08 13:56 UTC (permalink / raw)
To: davem, kuba, netdev, linux-rdma, linux-kernel; +Cc: Zheng Yongjun
Simplify the return expression.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
index c9c2962ad49f..786d2fc4b403 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
@@ -1893,13 +1893,8 @@ void esw_offloads_unload_rep(struct mlx5_eswitch *esw, u16 vport_num)
static int mlx5_esw_offloads_pair(struct mlx5_eswitch *esw,
struct mlx5_eswitch *peer_esw)
{
- int err;
- err = esw_add_fdb_peer_miss_rules(esw, peer_esw->dev);
- if (err)
- return err;
-
- return 0;
+ return esw_add_fdb_peer_miss_rules(esw, peer_esw->dev);
}
static void mlx5_esw_offloads_unpair(struct mlx5_eswitch *esw)
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()
2020-12-08 13:56 [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair() Zheng Yongjun
@ 2020-12-08 19:19 ` Jakub Kicinski
2020-12-09 0:25 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-12-08 19:19 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: davem, netdev, linux-rdma, linux-kernel, Saeed Mahameed
On Tue, 8 Dec 2020 21:56:25 +0800 Zheng Yongjun wrote:
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Please make sure to CC maintainers on your patches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()
2020-12-08 13:56 [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair() Zheng Yongjun
2020-12-08 19:19 ` Jakub Kicinski
@ 2020-12-09 0:25 ` David Miller
2020-12-15 7:24 ` Saeed Mahameed
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2020-12-09 0:25 UTC (permalink / raw)
To: zhengyongjun3; +Cc: kuba, netdev, linux-rdma, linux-kernel
From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Tue, 8 Dec 2020 21:56:25 +0800
> Simplify the return expression.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()
2020-12-09 0:25 ` David Miller
@ 2020-12-15 7:24 ` Saeed Mahameed
0 siblings, 0 replies; 4+ messages in thread
From: Saeed Mahameed @ 2020-12-15 7:24 UTC (permalink / raw)
To: David Miller, zhengyongjun3; +Cc: kuba, netdev, linux-rdma, linux-kernel
On Tue, 2020-12-08 at 16:25 -0800, David Miller wrote:
> From: Zheng Yongjun <zhengyongjun3@huawei.com>
> Date: Tue, 8 Dec 2020 21:56:25 +0800
>
> > Simplify the return expression.
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
>
> Applied.
>
Hey Dave, it's great to have you back!
I still don't see this patch in net-next, i will take it to my tree
and submit it in my next pr.
Thanks,
Saeed.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-15 7:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-08 13:56 [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair() Zheng Yongjun
2020-12-08 19:19 ` Jakub Kicinski
2020-12-09 0:25 ` David Miller
2020-12-15 7:24 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).