From: David Miller <davem@davemloft.net>
To: cmi@nvidia.com
Cc: netdev@vger.kernel.org, pablo@netfilter.org, kuba@kernel.org,
roid@nvidia.com
Subject: Re: [PATCH net v2] net: flow_offload: Fix memory leak for indirect flow block
Date: Wed, 09 Dec 2020 16:10:41 -0800 (PST) [thread overview]
Message-ID: <20201209.161041.1128905467938677328.davem@davemloft.net> (raw)
In-Reply-To: <20201208024835.63253-1-cmi@nvidia.com>
From: Chris Mi <cmi@nvidia.com>
Date: Tue, 8 Dec 2020 10:48:35 +0800
> The offending commit introduces a cleanup callback that is invoked
> when the driver module is removed to clean up the tunnel device
> flow block. But it returns on the first iteration of the for loop.
> The remaining indirect flow blocks will never be freed.
>
> Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure")
> CC: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Chris Mi <cmi@nvidia.com>
> Reviewed-by: Roi Dayan <roid@nvidia.com>
> ---
> v2: - CC relevant people.
Applied, trhanks.
prev parent reply other threads:[~2020-12-10 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 2:48 [PATCH net v2] net: flow_offload: Fix memory leak for indirect flow block Chris Mi
2020-12-10 0:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209.161041.1128905467938677328.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cmi@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=roid@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).