From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EFEAC4361B for ; Thu, 10 Dec 2020 00:12:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D98AB23770 for ; Thu, 10 Dec 2020 00:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbgLJALp (ORCPT ); Wed, 9 Dec 2020 19:11:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726777AbgLJALo (ORCPT ); Wed, 9 Dec 2020 19:11:44 -0500 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA20FC0613CF for ; Wed, 9 Dec 2020 16:11:04 -0800 (PST) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 539B84D259C15; Wed, 9 Dec 2020 16:11:02 -0800 (PST) Date: Wed, 09 Dec 2020 16:10:41 -0800 (PST) Message-Id: <20201209.161041.1128905467938677328.davem@davemloft.net> To: cmi@nvidia.com Cc: netdev@vger.kernel.org, pablo@netfilter.org, kuba@kernel.org, roid@nvidia.com Subject: Re: [PATCH net v2] net: flow_offload: Fix memory leak for indirect flow block From: David Miller In-Reply-To: <20201208024835.63253-1-cmi@nvidia.com> References: <20201208024835.63253-1-cmi@nvidia.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Wed, 09 Dec 2020 16:11:02 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Chris Mi Date: Tue, 8 Dec 2020 10:48:35 +0800 > The offending commit introduces a cleanup callback that is invoked > when the driver module is removed to clean up the tunnel device > flow block. But it returns on the first iteration of the for loop. > The remaining indirect flow blocks will never be freed. > > Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block infrastructure") > CC: Pablo Neira Ayuso > Signed-off-by: Chris Mi > Reviewed-by: Roi Dayan > --- > v2: - CC relevant people. Applied, trhanks.