From: Simon Horman <simon.horman@netronome.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
oss-drivers@netronome.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next] nfp: silence set but not used warning with IPV6=n
Date: Wed, 9 Dec 2020 17:53:22 +0100 [thread overview]
Message-ID: <20201209165319.GA8699@netronome.com> (raw)
In-Reply-To: <20201209161821.1040796-1-kuba@kernel.org>
On Wed, Dec 09, 2020 at 08:18:21AM -0800, Jakub Kicinski wrote:
> Test robot reports:
>
> drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_rx_resync_req':
> drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used [-Wunused-but-set-variable]
> 477 | struct ipv6hdr *ipv6h;
> | ^~~~~
> In file included from include/linux/compiler_types.h:65,
> from <command-line>:
> drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':
> include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]
> 208 | # define fallthrough __attribute__((__fallthrough__))
> | ^~~~~~~~~~~~~
> drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough'
> 299 | fallthrough;
> | ^~~~~~~~~~~
>
> Use the IPv6 header in the switch, it doesn't matter which header
> we use to read the version field.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Thanks Jakub,
this looks good to me.
Reviewed-by: Simon Horman <simon.horman@netronome.com>
next prev parent reply other threads:[~2020-12-09 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 16:18 [PATCH net-next] nfp: silence set but not used warning with IPV6=n Jakub Kicinski
2020-12-09 16:53 ` Simon Horman [this message]
2020-12-10 3:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209165319.GA8699@netronome.com \
--to=simon.horman@netronome.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).