From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68F6C433FE for ; Wed, 9 Dec 2020 21:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7EF123D37 for ; Wed, 9 Dec 2020 21:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731932AbgLIVBx (ORCPT ); Wed, 9 Dec 2020 16:01:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbgLIVBw (ORCPT ); Wed, 9 Dec 2020 16:01:52 -0500 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 885E2C061793 for ; Wed, 9 Dec 2020 13:01:12 -0800 (PST) Received: by mail-qt1-x843.google.com with SMTP id y15so2051161qtv.5 for ; Wed, 09 Dec 2020 13:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ExCyT+SCyEhlsRTDkdqpqOCI/2LqGwYMywiKe/9st7A=; b=NurNnQGxxSkfZQjGs80r0MdCe57Y8YszlEuoc2elRd+DXWUpnANMlVzzuNTwPH+FN+ zrqk3CEFeTymZ/WhIRsmc63GudmjGSnyxwYmWSoC7rKyY2wzMZjlz/CVmZBX/VJJMIz3 +V7G4VxJctuBUoEtBaHlhidY8aE2WRrnpXG+GwJRVVqPfdFowfLmuJm1T6YkWhhmQCVx 7ZZCzoKpifkSTMUHpgTPNtkx7asho6Ik5kc1O3GeQRJUvA7miROIB2zSIeCZSCS+pDTA hyyaBCcccsB9P998NCm428ljTqSZ0zroaXp50HK7VLiXfGKPXTaFmUK1acRBz1R7/fq3 Jw7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ExCyT+SCyEhlsRTDkdqpqOCI/2LqGwYMywiKe/9st7A=; b=q2g5AAdQf54dSURNkBITuWnQhe3dMj4bN06501lsegIzrRiYo//ewNsjczJ8D2VYoJ iXGPoYPdJse9K3VsxCPKfdvp7WD9/T3JWcPsttddNJo3NE4gkmcNh1zEGpRPwM+06NUB PK/OZwLVC4BO/Hn2k6nKK2YP86HCdg4Yw7d049aP59qDAQKfkmuebLaFbfGAdGyoM4Py qiozc1ID55tppiaPNEimLLhIUhVbpi6koDAiNCBqde+tRdVOBXCTVmjdsfK4PEwRLT+Q GBA4fR0QCg3S9q3R6F+0qtGvgzozGQfeLjE7zGHZXL4KuBT4R6u/uvgKCt31ryWRAIVZ +Cqg== X-Gm-Message-State: AOAM530Y+fad/VkWat5mKsStVYMcxF8eJHtK/xaD+N3vUZmZj3TVxhiB nYP8eaUS7jVwKSSNyDLaFlbMVw== X-Google-Smtp-Source: ABdhPJyXjhK+L8ctOi5c31cd5zlhIMw/LoMHFxPJanVLeUpnUks4dOAQNYla3t3nAPX+6am0z/Nk+g== X-Received: by 2002:aed:2ba5:: with SMTP id e34mr5353832qtd.146.1607547671626; Wed, 09 Dec 2020 13:01:11 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id y9sm1914394qtm.96.2020.12.09.13.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 13:01:10 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kn6aD-008OUf-U6; Wed, 09 Dec 2020 17:01:09 -0400 Date: Wed, 9 Dec 2020 17:01:09 -0400 From: Jason Gunthorpe To: Jakub Kicinski Cc: Leon Romanovsky , Zou Wei , saeedm@nvidia.com, davem@davemloft.net, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] net/mlx5_core: remove unused including Message-ID: <20201209210109.GX5487@ziepe.ca> References: <1607343240-39155-1-git-send-email-zou_wei@huawei.com> <20201208112226.1bb31229@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> <20201209062100.GK4430@unreal> <20201209090446.7daadd13@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209090446.7daadd13@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Dec 09, 2020 at 09:04:46AM -0800, Jakub Kicinski wrote: > On Wed, 9 Dec 2020 08:21:00 +0200 Leon Romanovsky wrote: > > On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > > > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > > > Remove including that don't need it. > > > > > > > > Signed-off-by: Zou Wei > > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > > > index 989c70c..82ecc161 100644 > > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > > > @@ -30,7 +30,6 @@ > > > > * SOFTWARE. > > > > */ > > > > > > > > -#include > > > > #include > > > > #include > > > > #include > > > > Jakub, > > > > You probably doesn't have latest net-next. > > > > In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and > > name"), I removed "strlcpy(drvinfo->version, UTS_RELEASE, > > sizeof(drvinfo->version));" line. > > > > The patch is ok, but should have Fixes line. > > Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") > > Hm. Pretty sure our build bot gets a fresh copy before testing. > Must had been some timing issue, perhaps? Looks like the commit > came in with the auxbus merge. mlx5-next is in linux-next independently so people will be sending fixes against stuff in linux-next before it hits net-next. Jason