From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Sven Auhagen <sven.auhagen@voleatech.de>,
netdev@vger.kernel.org, sassmann@redhat.com,
anthony.l.nguyen@intel.com,
Dan Carpenter <dan.carpenter@oracle.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Sandeep Penigalapati <sandeep.penigalapati@intel.com>
Subject: [net 1/9] igb: XDP xmit back fix error code
Date: Wed, 9 Dec 2020 17:02:44 -0800 [thread overview]
Message-ID: <20201210010252.4029245-2-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20201210010252.4029245-1-anthony.l.nguyen@intel.com>
From: Sven Auhagen <sven.auhagen@voleatech.de>
The igb XDP xmit back function should only return
defined error codes.
Fixes: 9cbc948b5a20 ("igb: add XDP support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 5fc2c381da55..08cc6f59aa2e 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -2910,7 +2910,7 @@ static int igb_xdp_xmit_back(struct igb_adapter *adapter, struct xdp_buff *xdp)
*/
tx_ring = adapter->xdp_prog ? igb_xdp_tx_queue_mapping(adapter) : NULL;
if (unlikely(!tx_ring))
- return -ENXIO;
+ return IGB_XDP_CONSUMED;
nq = txring_txq(tx_ring);
__netif_tx_lock(nq, cpu);
--
2.26.2
next prev parent reply other threads:[~2020-12-10 1:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 1:02 [net 0/9][pull request] Intel Wired LAN Driver Updates 2020-12-09 Tony Nguyen
2020-12-10 1:02 ` Tony Nguyen [this message]
2020-12-10 1:02 ` [net 2/9] igb: take VLAN double header into account Tony Nguyen
2020-12-10 1:02 ` [net 3/9] igb: XDP extack message on error Tony Nguyen
2020-12-10 1:02 ` [net 4/9] igb: skb add metasize for xdp Tony Nguyen
2020-12-10 1:02 ` [net 5/9] igb: use xdp_do_flush Tony Nguyen
2020-12-10 1:02 ` [net 6/9] igb: avoid transmit queue timeout in xdp path Tony Nguyen
2020-12-10 1:02 ` [net 7/9] i40e: avoid premature Rx buffer reuse Tony Nguyen
2020-12-10 1:02 ` [net 8/9] ixgbe: " Tony Nguyen
2020-12-10 1:02 ` [net 9/9] ice: " Tony Nguyen
2020-12-10 2:49 ` [net 0/9][pull request] Intel Wired LAN Driver Updates 2020-12-09 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210010252.4029245-2-anthony.l.nguyen@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sandeep.penigalapati@intel.com \
--cc=sassmann@redhat.com \
--cc=sven.auhagen@voleatech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).