From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: kuba@kernel.org, davem@davemloft.net,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
jhugo@codeaurora.org
Subject: Re: [PATCH v2 2/3] net: mhi: Get RX queue size from MHI core
Date: Fri, 11 Dec 2020 11:08:00 +0530 [thread overview]
Message-ID: <20201211053800.GC4222@work> (raw)
In-Reply-To: <1607598951-2340-2-git-send-email-loic.poulain@linaro.org>
On Thu, Dec 10, 2020 at 12:15:50PM +0100, Loic Poulain wrote:
> The RX queue size can be determined at runtime by retrieving the
> number of available transfer descriptors.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> v2: Fixed commit message typo
>
> drivers/net/mhi_net.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
> index 8e72d94..0333e07 100644
> --- a/drivers/net/mhi_net.c
> +++ b/drivers/net/mhi_net.c
> @@ -256,9 +256,6 @@ static int mhi_net_probe(struct mhi_device *mhi_dev,
> mhi_netdev->mdev = mhi_dev;
> SET_NETDEV_DEV(ndev, &mhi_dev->dev);
>
> - /* All MHI net channels have 128 ring elements (at least for now) */
> - mhi_netdev->rx_queue_sz = 128;
> -
> INIT_DELAYED_WORK(&mhi_netdev->rx_refill, mhi_net_rx_refill_work);
> u64_stats_init(&mhi_netdev->stats.rx_syncp);
> u64_stats_init(&mhi_netdev->stats.tx_syncp);
> @@ -268,6 +265,9 @@ static int mhi_net_probe(struct mhi_device *mhi_dev,
> if (err)
> goto out_err;
>
> + /* Number of transfer descriptors determines size of the queue */
> + mhi_netdev->rx_queue_sz = mhi_get_free_desc_count(mhi_dev, DMA_FROM_DEVICE);
> +
This value is not static right? You might need to fetch the count in
mhi_net_rx_refill_work().
Thanks,
Mani
> err = register_netdev(ndev);
> if (err)
> goto out_err;
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-12-11 5:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 11:15 [PATCH v2 1/3] bus: mhi: core: Add helper API to return number of free TREs Loic Poulain
2020-12-10 11:15 ` [PATCH v2 2/3] net: mhi: Get RX queue size from MHI core Loic Poulain
2020-12-11 5:38 ` Manivannan Sadhasivam [this message]
2020-12-11 9:40 ` Loic Poulain
2020-12-11 10:15 ` Manivannan Sadhasivam
2020-12-11 10:40 ` Loic Poulain
2020-12-10 11:15 ` [PATCH v2 3/3] net: mhi: Add dedicated alloc thread Loic Poulain
2020-12-12 20:55 ` Jakub Kicinski
2020-12-14 9:19 ` Loic Poulain
2020-12-14 19:47 ` Jakub Kicinski
2020-12-15 12:09 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211053800.GC4222@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=davem@davemloft.net \
--cc=jhugo@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).