From: Mark Brown <broonie@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Daniel Diaz <daniel.diaz@linaro.org>,
Veronika Kabatova <vkabatov@redhat.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH] selftests: Skip BPF seftests by default
Date: Fri, 11 Dec 2020 12:46:18 +0000 [thread overview]
Message-ID: <20201211124618.GA4929@sirena.org.uk> (raw)
In-Reply-To: <7e0ca62b-ff63-7d26-355f-c49e98a0ef36@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On Thu, Dec 10, 2020 at 04:41:33PM -0700, Shuah Khan wrote:
> On 12/10/20 12:11 PM, Alexei Starovoitov wrote:
> > I'm fine with this, but I'd rather make an obvious second step right away
> > and move selftests/bpf into a different directory.
> Why is this an obvious second step? If people want to run bpf, they can
> build and run. How does moving it out of selftests directory help? It
> would become harder on users that want to run the test.
> I don't support moving bpf out of selftests directory in the interest
> of Linux kernel quality and validation.
> Let's think big picture and kernel community as a whole.
Yeah, I don't see an obvious motivation for doing that either - what
problem does it solve? For people running suites it's helpful to have
fewer testsuites and test infrastructures to integrate with. The work
needed for the dependencies is going to be the same no matter where we
put the tests and moving out of the shared infrastructure creates some
additional work.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-11 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 18:52 [PATCH] selftests: Skip BPF seftests by default Mark Brown
2020-12-10 19:11 ` Alexei Starovoitov
2020-12-10 23:41 ` Shuah Khan
2020-12-11 12:46 ` Mark Brown [this message]
2020-12-16 22:05 ` Seth Forshee
2020-12-17 13:07 ` Mark Brown
2020-12-17 15:53 ` Shuah Khan
2020-12-17 18:32 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211124618.GA4929@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel.diaz@linaro.org \
--cc=daniel@iogearbox.net \
--cc=guillaume.tucker@collabora.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=khilman@baylibre.com \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=songliubraving@fb.com \
--cc=vkabatov@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).