From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Dan Williams <dcbw@redhat.com>,
Greg KH <gregkh@linuxfoundation.org>,
Hemant Kumar <hemantk@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
jhugo@codeaurora.org, bbhatt@codeaurora.org,
loic.poulain@linaro.org, netdev@vger.kernel.org
Subject: Re: [PATCH v17 3/3] bus: mhi: Add userspace client interface driver
Date: Sat, 12 Dec 2020 11:38:18 +0530 [thread overview]
Message-ID: <20201212060818.GA10816@thinkpad> (raw)
In-Reply-To: <20201211200816.7062c3f9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Dec 11, 2020 at 08:08:16PM -0800, Jakub Kicinski wrote:
> On Fri, 11 Dec 2020 11:37:34 -0600 Dan Williams wrote:
> > Just to re-iterate: QMI ~= AT commands ~= MBIM (not quite, but same
> > level)
> >
> > We already do QMI-over-USB, or AT-over-CDC-ACM. This is QMI-over-MHI.
>
> Why do we need a different QMI-over-X for every X? If you say there
> are already chardev interfaces to configure WWAN why not provide one
> of those?
>
Just because the underlying PHY is different and it offers more services than
just configuring the modem (downloading crash dump, firmware download etc...)
The existing chardev nodes are closely tied to the physical interfaces. For
instance, /dev/cdc_wdm is used by the USB based WWAN devices. So we really can't
reuse it for MHI/PCIe.
> > It's not networking data plane. It's WWAN device configuration.
>
> Ack. Not that network config doesn't fall under networking, but eh.
> I wonder - did DaveM ever ack this, or was it just out of his sight
> enough, behind the cdev, to never trigger a nack?
>
> > There are no current kernel APIs for this, and I really don't think we
> > want there to be. The API surface is *huge* and we definitely don't
> > want that in-kernel.
>
> It is what it is today for WWAN. I don't think anyone in the
> development community or among users is particularly happy about
> the situation. Which makes it rather self evident why there is
> so much apprehension about this patch set. It's going to be
> a user space channel for everything Qualcomm - AI accelerator etc.
> Widening the WWAN status quo to more device types.
Well not everything Qualcomm but for just the subsystems where there is no
standardization right now. I think we went too far ahead for standardizing
the modems.
Thanks,
Mani
next prev parent reply other threads:[~2020-12-12 6:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 7:04 [PATCH v17 0/3] userspace MHI client interface driver Hemant Kumar
2020-12-11 7:04 ` [PATCH v17 1/3] bus: mhi: core: Move MHI_MAX_MTU to external header file Hemant Kumar
2020-12-11 7:04 ` [PATCH v17 2/3] docs: Add documentation for userspace client interface Hemant Kumar
2020-12-11 7:04 ` [PATCH v17 3/3] bus: mhi: Add userspace client interface driver Hemant Kumar
2020-12-11 7:44 ` Greg KH
2020-12-11 8:44 ` Manivannan Sadhasivam
2020-12-11 8:53 ` Loic Poulain
2020-12-11 17:37 ` Dan Williams
2020-12-12 4:08 ` Jakub Kicinski
2020-12-12 6:08 ` Manivannan Sadhasivam [this message]
2020-12-14 9:16 ` Daniele Palmas
-- strict thread matches above, loose matches on Subject: below --
2020-12-11 8:55 Carl Yin(殷张成)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201212060818.GA10816@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=dcbw@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).