* [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform
@ 2020-12-13 12:06 Leon Romanovsky
2020-12-13 12:36 ` Leon Romanovsky
0 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2020-12-13 12:06 UTC (permalink / raw)
To: Jakub Kicinski, David S. Miller, Saeed Mahameed
Cc: Parav Pandit, Stephen Rothwell, netdev
From: Parav Pandit <parav@nvidia.com>
MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field.
Defining an enum for such bit fields on 32-bit platform results in below
warning.
./include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow]
^
./include/linux/mlx5/mlx5_ifc.h:10716:46: note: in expansion of macro ‘BIT’
MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT(0x20),
^~~
Use 32-bit friendly BIT_ULL macro.
Fixes: 2a2970891647 ("net/mlx5: Add sample offload hardware bits and structures")
Signed-off-by: Parav Pandit <parav@nvidia.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
include/linux/mlx5/mlx5_ifc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index 2006795fd522..8a359b8bee52 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -10709,9 +10709,9 @@ struct mlx5_ifc_affiliated_event_header_bits {
};
enum {
- MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_ENCRYPTION_KEY = BIT(0xc),
- MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_IPSEC = BIT(0x13),
- MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT(0x20),
+ MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_ENCRYPTION_KEY = BIT_ULL(0xc),
+ MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_IPSEC = BIT_ULL(0x13),
+ MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT_ULL(0x20),
};
enum {
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform
2020-12-13 12:06 [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform Leon Romanovsky
@ 2020-12-13 12:36 ` Leon Romanovsky
2020-12-14 20:08 ` Saeed Mahameed
0 siblings, 1 reply; 6+ messages in thread
From: Leon Romanovsky @ 2020-12-13 12:36 UTC (permalink / raw)
To: Jakub Kicinski, David S. Miller, Saeed Mahameed
Cc: Parav Pandit, Stephen Rothwell, netdev
On Sun, Dec 13, 2020 at 02:06:41PM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav@nvidia.com>
>
> MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field.
>
> Defining an enum for such bit fields on 32-bit platform results in below
> warning.
>
> ./include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow]
> ^
> ./include/linux/mlx5/mlx5_ifc.h:10716:46: note: in expansion of macro ‘BIT’
> MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT(0x20),
> ^~~
>
> Use 32-bit friendly BIT_ULL macro.
>
> Fixes: 2a2970891647 ("net/mlx5: Add sample offload hardware bits and structures")
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> include/linux/mlx5/mlx5_ifc.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> index 2006795fd522..8a359b8bee52 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -10709,9 +10709,9 @@ struct mlx5_ifc_affiliated_event_header_bits {
> };
>
> enum {
> - MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_ENCRYPTION_KEY = BIT(0xc),
> - MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_IPSEC = BIT(0x13),
> - MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT(0x20),
> + MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_ENCRYPTION_KEY = BIT_ULL(0xc),
> + MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_IPSEC = BIT_ULL(0x13),
> + MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT_ULL(0x20),
Or even better is to use "1ULL << 0x20" directly because we are not
including bits.h in this mlx5_ifc.h file.
Should I resend?
Thanks
> };
>
> enum {
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform
2020-12-13 12:36 ` Leon Romanovsky
@ 2020-12-14 20:08 ` Saeed Mahameed
2020-12-17 0:14 ` Jakub Kicinski
0 siblings, 1 reply; 6+ messages in thread
From: Saeed Mahameed @ 2020-12-14 20:08 UTC (permalink / raw)
To: Leon Romanovsky, Jakub Kicinski, David S. Miller
Cc: Parav Pandit, Stephen Rothwell, netdev
On Sun, 2020-12-13 at 14:36 +0200, Leon Romanovsky wrote:
> On Sun, Dec 13, 2020 at 02:06:41PM +0200, Leon Romanovsky wrote:
> > From: Parav Pandit <parav@nvidia.com>
> >
> > MLX5_GENERAL_OBJECT_TYPES types bitfield is 64-bit field.
> >
> > Defining an enum for such bit fields on 32-bit platform results in
> > below
> > warning.
> >
> > ./include/vdso/bits.h:7:26: warning: left shift count >= width of
> > type [-Wshift-count-overflow]
> > ^
> > ./include/linux/mlx5/mlx5_ifc.h:10716:46: note: in expansion of
> > macro ‘BIT’
> > MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT(0x20),
> > ^~~
> >
> > Use 32-bit friendly BIT_ULL macro.
> >
> > Fixes: 2a2970891647 ("net/mlx5: Add sample offload hardware bits
> > and structures")
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> > include/linux/mlx5/mlx5_ifc.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/mlx5/mlx5_ifc.h
> > b/include/linux/mlx5/mlx5_ifc.h
> > index 2006795fd522..8a359b8bee52 100644
> > --- a/include/linux/mlx5/mlx5_ifc.h
> > +++ b/include/linux/mlx5/mlx5_ifc.h
> > @@ -10709,9 +10709,9 @@ struct
> > mlx5_ifc_affiliated_event_header_bits {
> > };
> >
> > enum {
> > - MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_ENCRYPTION_KEY = BIT(0xc),
> > - MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_IPSEC = BIT(0x13),
> > - MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT(0x20),
> > + MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_ENCRYPTION_KEY =
> > BIT_ULL(0xc),
> > + MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_IPSEC = BIT_ULL(0x13),
> > + MLX5_HCA_CAP_GENERAL_OBJECT_TYPES_SAMPLER = BIT_ULL(0x20),
>
> Or even better is to use "1ULL << 0x20" directly because we are not
> including bits.h in this mlx5_ifc.h file.
>
> Should I resend?
>
> Thanks
I will change this and attach this patch to my PR of the SF support.
Thanks,
Saeed.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform
2020-12-14 20:08 ` Saeed Mahameed
@ 2020-12-17 0:14 ` Jakub Kicinski
2020-12-17 18:52 ` Jakub Kicinski
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2020-12-17 0:14 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Leon Romanovsky, David S. Miller, Parav Pandit, Stephen Rothwell,
netdev
On Mon, 14 Dec 2020 12:08:46 -0800 Saeed Mahameed wrote:
> I will change this and attach this patch to my PR of the SF support.
Looks like the SF discussion will not wind down in time to make this
merge window, so I think I'm going to take this in after all. Okay?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform
2020-12-17 0:14 ` Jakub Kicinski
@ 2020-12-17 18:52 ` Jakub Kicinski
2020-12-17 19:53 ` Saeed Mahameed
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2020-12-17 18:52 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Leon Romanovsky, David S. Miller, Parav Pandit, Stephen Rothwell,
netdev
On Wed, 16 Dec 2020 16:14:45 -0800 Jakub Kicinski wrote:
> On Mon, 14 Dec 2020 12:08:46 -0800 Saeed Mahameed wrote:
> > I will change this and attach this patch to my PR of the SF support.
>
> Looks like the SF discussion will not wind down in time to make this
> merge window, so I think I'm going to take this in after all. Okay?
Done.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform
2020-12-17 18:52 ` Jakub Kicinski
@ 2020-12-17 19:53 ` Saeed Mahameed
0 siblings, 0 replies; 6+ messages in thread
From: Saeed Mahameed @ 2020-12-17 19:53 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Leon Romanovsky, David S. Miller, Parav Pandit, Stephen Rothwell,
netdev
On Thu, 2020-12-17 at 10:52 -0800, Jakub Kicinski wrote:
> On Wed, 16 Dec 2020 16:14:45 -0800 Jakub Kicinski wrote:
> > On Mon, 14 Dec 2020 12:08:46 -0800 Saeed Mahameed wrote:
> > > I will change this and attach this patch to my PR of the SF
> > > support.
> >
> > Looks like the SF discussion will not wind down in time to make
> > this
> > merge window, so I think I'm going to take this in after all. Okay?
>
> Done.
Thanks Jakub for your hard work and support!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-17 19:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-13 12:06 [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform Leon Romanovsky
2020-12-13 12:36 ` Leon Romanovsky
2020-12-14 20:08 ` Saeed Mahameed
2020-12-17 0:14 ` Jakub Kicinski
2020-12-17 18:52 ` Jakub Kicinski
2020-12-17 19:53 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).