From: Kevin Lo <kevlo@kevlo.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Sasha Neftin <sasha.neftin@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr
Date: Mon, 14 Dec 2020 09:21:12 +0800 [thread overview]
Message-ID: <20201214012112.GA84571@ns.kevlo.org> (raw)
In-Reply-To: <20201212140010.467d68bd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Sat, Dec 12, 2020 at 02:00:10PM -0800, Jakub Kicinski wrote:
>
> On Fri, 11 Dec 2020 22:34:56 +0800 Kevin Lo wrote:
> > This patch sets the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr.
> > Without this change it wouldn't lead to a shadow RAM write EEWR timeout.
> >
> > Signed-off-by: Kevin Lo <kevlo@kevlo.org>
>
> This is a fix, please add a Fixes tag.
>
> Please CC the maintainers:
>
> M: Jesse Brandeburg <jesse.brandeburg@intel.com>
> M: Tony Nguyen <anthony.l.nguyen@intel.com>
I will update the Fixes tag and send V2, thanks.
prev parent reply other threads:[~2020-12-14 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 14:34 [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr Kevin Lo
2020-12-12 22:00 ` Jakub Kicinski
2020-12-14 1:21 ` Kevin Lo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214012112.GA84571@ns.kevlo.org \
--to=kevlo@kevlo.org \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).