From: Stephen Hemminger <stephen@networkplumber.org>
To: Maxim Mikityanskiy <maximmi@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, David Ahern <dsahern@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Yossi Kuperman <yossiku@nvidia.com>,
Maxim Mikityanskiy <maximmi@nvidia.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] tc/htb: Hierarchical QoS hardware offload
Date: Tue, 15 Dec 2020 14:26:53 -0800 [thread overview]
Message-ID: <20201215142653.2a16e888@hermes.local> (raw)
In-Reply-To: <20201215074213.32652-1-maximmi@mellanox.com>
On Tue, 15 Dec 2020 09:42:08 +0200
Maxim Mikityanskiy <maximmi@mellanox.com> wrote:
> + print_uint(PRINT_ANY, "offload", " offload %d", !!tb[TCA_HTB_OFFLOAD]);
This is not the best way to represent a boolean flag in JSON.
Also it breaks the "output should be the same as command line" mantra.
My preference is json_null to indicate presence of a flag.
Something like:
if (tb[TCA_HTB_OFFLOAD])
print_null(PRINT_ANY, "offload", "offload", NULL);
next prev parent reply other threads:[~2020-12-15 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 7:42 [PATCH iproute2-next] tc/htb: Hierarchical QoS hardware offload Maxim Mikityanskiy
2020-12-15 7:42 ` [PATCH net-next v3 0/4] HTB offload Maxim Mikityanskiy
2020-12-15 7:42 ` [PATCH net-next v3 1/4] net: sched: Add multi-queue support to sch_tree_lock Maxim Mikityanskiy
2020-12-15 7:42 ` [PATCH net-next v3 2/4] sch_htb: Hierarchical QoS hardware offload Maxim Mikityanskiy
2020-12-22 1:17 ` Jakub Kicinski
2021-01-04 21:55 ` Maxim Mikityanskiy
2020-12-15 7:42 ` [PATCH net-next v3 3/4] sch_htb: Stats for offloaded HTB Maxim Mikityanskiy
2020-12-15 7:42 ` [PATCH net-next v3 4/4] net/mlx5e: Support HTB offload Maxim Mikityanskiy
2020-12-15 22:26 ` Stephen Hemminger [this message]
[not found] ` <8c818766-ec3f-4c0b-f737-ec558613b946@gmail.com>
2021-02-02 11:46 ` [PATCH iproute2-next] tc/htb: Hierarchical QoS hardware offload Maxim Mikityanskiy
2021-02-02 15:32 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215142653.2a16e888@hermes.local \
--to=stephen@networkplumber.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=maximmi@mellanox.com \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yossiku@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).