From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C6BCC2BBCA for ; Wed, 16 Dec 2020 16:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A2C122283 for ; Wed, 16 Dec 2020 16:05:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726232AbgLPQFi (ORCPT ); Wed, 16 Dec 2020 11:05:38 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:57684 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726110AbgLPQFh (ORCPT ); Wed, 16 Dec 2020 11:05:37 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kpZIF-00CJSy-3I; Wed, 16 Dec 2020 17:04:47 +0100 Date: Wed, 16 Dec 2020 17:04:47 +0100 From: Andrew Lunn To: Divya Koppera Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, marex@denx.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v3 net-next 1/2] net: phy: mchp: Add interrupt support for Link up and Link down to LAN8814 phy Message-ID: <20201216160447.GJ2901580@lunn.ch> References: <20201216152528.6457-1-Divya.Koppera@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201216152528.6457-1-Divya.Koppera@microchip.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +static irqreturn_t lan8814_handle_interrupt(struct phy_device *phydev) > +{ > + int irq_status; > + > + irq_status = phy_read(phydev, LAN8814_INTS); > + if (irq_status < 0) > + return IRQ_NONE; > + > + if (irq_status & LAN8814_INTS_ALL) > + phy_mac_interrupt(phydev); This is a PHY driver, so it should not be using the MAC API call. Please change to phy_trigger_machine(phydev); Andrew