netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
	vivien.didelot@gmail.com, f.fainelli@gmail.com,
	j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
	netdev@vger.kernel.org
Subject: Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support
Date: Wed, 16 Dec 2020 20:02:48 +0200	[thread overview]
Message-ID: <20201216180248.u3uhrec2ssveubyp@skbuf> (raw)
In-Reply-To: <20201216160056.27526-4-tobias@waldekranz.com>

On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote:
> +	/* Drivers that benefit from having an ID associated with each
> +	 * offloaded LAG should set this to the maximum number of
> +	 * supported IDs. DSA will then maintain a mapping of _at
> +	 * least_ these many IDs, accessible to drivers via
> +	 * dsa_tree_lag_id().
           ~~~~~~~~~~~~~~~
           you named it dsa_lag_id() in the end.

> +	 */
> +	unsigned int		num_lag_ids;
[...]
> +	/* No IDs left, which is OK. Some drivers do not need it. The
> +	 * ones that do, e.g. mv88e6xxx, will discover that
> +	 * dsa_tree_lag_id returns an error for this device when
           ~~~~~~~~~~~~~~~
           same thing here.

> +	 * joining the LAG. The driver can then return -EOPNOTSUPP
> +	 * back to DSA, which will fall back to a software LAG.
> +	 */

  parent reply	other threads:[~2020-12-16 18:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 16:00 [PATCH v4 net-next 0/5] net: dsa: Link aggregation support Tobias Waldekranz
2020-12-16 16:00 ` [PATCH v4 net-next 1/5] net: bonding: Notify ports about their initial state Tobias Waldekranz
2020-12-16 16:28   ` Vladimir Oltean
2020-12-16 16:00 ` [PATCH v4 net-next 2/5] net: dsa: Don't offload port attributes on standalone ports Tobias Waldekranz
2020-12-16 16:27   ` Vladimir Oltean
2020-12-16 19:32     ` Tobias Waldekranz
2020-12-16 16:00 ` [PATCH v4 net-next 3/5] net: dsa: Link aggregation support Tobias Waldekranz
2020-12-16 16:22   ` Vladimir Oltean
2020-12-16 19:47     ` Tobias Waldekranz
2020-12-16 18:02   ` Vladimir Oltean [this message]
2020-12-16 19:49     ` Tobias Waldekranz
2020-12-16 18:44   ` Vladimir Oltean
2020-12-16 20:09     ` Tobias Waldekranz
2020-12-17 18:31       ` Vladimir Oltean
2020-12-16 16:00 ` [PATCH v4 net-next 4/5] net: dsa: mv88e6xxx: " Tobias Waldekranz
2020-12-16 19:04   ` Vladimir Oltean
2020-12-16 20:21     ` Tobias Waldekranz
2020-12-16 16:00 ` [PATCH v4 net-next 5/5] net: dsa: tag_dsa: Support reception of packets from LAG devices Tobias Waldekranz
2020-12-16 19:14   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216180248.u3uhrec2ssveubyp@skbuf \
    --to=olteanv@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=j.vosburgh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tobias@waldekranz.com \
    --cc=vfalico@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).