From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
maze@google.com, lmb@cloudflare.com, shaun@tigera.io,
Lorenzo Bianconi <lorenzo@kernel.org>,
marek@cloudflare.com, John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
eyal.birger@gmail.com, colrack@gmail.com, brouer@redhat.com
Subject: Re: [PATCH bpf-next V8 5/8] bpf: drop MTU check when doing TC-BPF redirect to ingress
Date: Thu, 17 Dec 2020 17:10:57 +0100 [thread overview]
Message-ID: <20201217171057.734c79d8@carbon> (raw)
In-Reply-To: <20201217154655.42e89d08@carbon>
On Thu, 17 Dec 2020 15:46:55 +0100
Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> > > diff --git a/net/core/filter.c b/net/core/filter.c
> > > index d6125cfc49c3..4673afe59533 100644
> > > --- a/net/core/filter.c
> > > +++ b/net/core/filter.c
> > > @@ -2083,13 +2083,21 @@ static const struct bpf_func_proto bpf_csum_level_proto = {
> > >
> > > static inline int __bpf_rx_skb(struct net_device *dev, struct sk_buff *skb)
> > > {
> > > - return dev_forward_skb(dev, skb);
> > > + int ret = ____dev_forward_skb(dev, skb, false);
> > > +
> > > + if (likely(!ret)) {
> > > + skb->protocol = eth_type_trans(skb, dev);
> > > + skb_postpull_rcsum(skb, eth_hdr(skb), ETH_HLEN);
> > > + ret = netif_rx(skb);
> >
> > Why netif_rx() and not netif_rx_internal() as in dev_forward_skb() originally?
> > One extra call otherwise.
>
> This is because the function below calls netif_rx(), which is just
> outside patch-diff-window. Thus, it looked wrong/strange to call
> netif_rx_internal(), but sure I can use netif_rx_internal() instead.
Well, when building I found that we obviously cannot call
netif_rx_internal() as this is filter.c, else we get a build error:
net/core/filter.c:2091:9: error: implicit declaration of function ‘netif_rx_internal’ [-Werror=implicit-function-declaration]
2091 | ret = netif_rx_internal(skb);
| ^~~~~~~~~~~~~~~~~
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-12-17 16:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 18:06 [PATCH bpf-next V8 0/8] bpf: New approach for BPF MTU handling Jesper Dangaard Brouer
2020-11-27 18:06 ` [PATCH bpf-next V8 1/8] bpf: Remove MTU check in __bpf_skb_max_len Jesper Dangaard Brouer
2020-11-27 18:06 ` [PATCH bpf-next V8 2/8] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx Jesper Dangaard Brouer
2020-11-27 18:06 ` [PATCH bpf-next V8 3/8] bpf: bpf_fib_lookup return MTU value as output when looked up Jesper Dangaard Brouer
2020-12-02 22:23 ` Daniel Borkmann
2020-11-27 18:06 ` [PATCH bpf-next V8 4/8] bpf: add BPF-helper for MTU checking Jesper Dangaard Brouer
2020-12-02 23:23 ` Daniel Borkmann
2020-12-14 13:51 ` Jesper Dangaard Brouer
2020-11-27 18:06 ` [PATCH bpf-next V8 5/8] bpf: drop MTU check when doing TC-BPF redirect to ingress Jesper Dangaard Brouer
2020-12-02 23:43 ` Daniel Borkmann
2020-12-17 14:46 ` Jesper Dangaard Brouer
2020-12-17 16:10 ` Jesper Dangaard Brouer [this message]
2020-11-27 18:06 ` [PATCH bpf-next V8 6/8] bpf: make it possible to identify BPF redirected SKBs Jesper Dangaard Brouer
2020-12-03 0:06 ` Daniel Borkmann
2020-11-27 18:06 ` [PATCH bpf-next V8 7/8] selftests/bpf: use bpf_check_mtu in selftest test_cls_redirect Jesper Dangaard Brouer
2020-11-27 18:06 ` [PATCH bpf-next V8 8/8] bpf/selftests: tests using bpf_check_mtu BPF-helper Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217171057.734c79d8@carbon \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=colrack@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eyal.birger@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lmb@cloudflare.com \
--cc=lorenzo@kernel.org \
--cc=marek@cloudflare.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=shaun@tigera.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).