From: Kari Argillander <kari.argillander@gmail.com>
To: Daniel West <daniel.west.dev@gmail.com>
Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Daniel West <daniel.s.west.dev@gmail.com>
Subject: Re: [PATCH] staging: qlge: Removed duplicate word in comment.
Date: Sun, 20 Dec 2020 17:17:52 +0200 [thread overview]
Message-ID: <20201220151752.xadu24n57nocsfeg@kari-VirtualBox> (raw)
In-Reply-To: <20201219014829.362810-1-daniel.west.dev@gmail.com>
On Fri, Dec 18, 2020 at 05:48:29PM -0800, Daniel West wrote:
> This patch fixes the checkpatch warning:
>
> WARNING: Possible repeated word: 'and'
>
> Signed-off-by: Daniel West <daniel.s.west.dev@gmail.com>
> ---
> drivers/staging/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index e6b7baa12cd6..22167eca7c50 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3186,7 +3186,7 @@ static void ql_enable_msix(struct ql_adapter *qdev)
> "Running with legacy interrupts.\n");
> }
>
> -/* Each vector services 1 RSS ring and and 1 or more
> +/* Each vector services 1 RSS ring and 1 or more
> * TX completion rings. This function loops through
> * the TX completion rings and assigns the vector that
> * will service it. An example would be if there are
Patch it self looks good. I nit pick a little bit because this is
staging and were here to learn mostly. You should use imperative mood
in subject line. So Removed -> Remove. Also no period in subject line.
I'm also confused by your email. Other patch which you send has sign of
is with daniel.s.west.dev and another is daniel.west.dev. So do you use
both? I also think that you made this email becouse you want to get all
lkml mails. That is perfectly fine and many does this. But many does it
just for reading. That way if someone needs to send you email it wont be
lost because you do not read that email anymore. Many does that they
still send messages from they real email so that email do get so many
emails. This is ofcourse your decission I'm just telling you options.
--
Kari Argillander
next prev parent reply other threads:[~2020-12-20 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 1:48 [PATCH] staging: qlge: Removed duplicate word in comment Daniel West
2020-12-20 15:17 ` Kari Argillander [this message]
2020-12-28 14:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201220151752.xadu24n57nocsfeg@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=daniel.s.west.dev@gmail.com \
--cc=daniel.west.dev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox