From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: <netdev@vger.kernel.org>, <edumazet@google.com>,
<willemdebruijn.kernel@gmail.com>
Cc: <kernel-team@fb.com>
Subject: [PATCH 00/12 v2 RFC] Generic zcopy_* functions
Date: Mon, 21 Dec 2020 16:09:14 -0800 [thread overview]
Message-ID: <20201222000926.1054993-1-jonathan.lemon@gmail.com> (raw)
From: Jonathan Lemon <bsd@fb.com>
This is set of cleanup patches for zerocopy which are intended
to allow a introduction of a different zerocopy implementation.
The top level API will use the skb_zcopy_*() functions, while
the current TCP specific zerocopy ends up using msg_zerocopy_*()
calls.
There should be no functional changes from these patches.
v1->v2:
Break changes to skb_zcopy_put into 3 patches, in order to
make it easier to follow the changes. Add Willem's suggestion
about renaming sock_zerocopy_
Patch 1:
Move zerocopy bits from tx_flags into zc_flags for clarity.
These bits will be used in the RX path in the future.
Patch 2: remove dead function
Patch 3: simplify sock_zerocopy_put
Patch 4: push status/refcounts into sock_zerocopy_callback
Patch 5: replace sock_zerocopy_put with skb_zcopy_put
Patch 6: rename sock_zerocopy_get
Patch 7:
Add an optional skb parameter to callback, allowing access to
the attached skb from the callback.
Patch 8:
Add skb_zcopy_put_abort, and move zerocopy logic into the
callback function. There unfortunately is still a check
against the callback type here.
Patch 9:
Set the skb zc_flags from the ubuf being attached, instead
of a fixed value, allowing different initialization types.
Patch 10: Replace open-coded assignments
Patch 11: Relocate skb_zcopy_clear() in skb_release_data()
Patch 12: rename sock_zerocopy_ to msg_zerocpy_
Jonathan Lemon (12):
net: group skb_shinfo zerocopy related bits together.
skbuff: remove unused skb_zcopy_abort function
skbuff: simplify sock_zerocopy_put
skbuff: Push status and refcounts into sock_zerocopy_callback
skbuff: replace sock_zerocopy_put() with skb_zcopy_put()
skbuff: replace sock_zerocopy_get with skb_zcopy_get
skbuff: Add skb parameter to the ubuf zerocopy callback
skbuff: Call sock_zerocopy_put_abort from skb_zcopy_put_abort
skbuff: add zc_flags to ubuf_info for ubuf setup
tap/tun: use skb_zcopy_set() instead of open coded assignment
skbuff: Call skb_zcopy_clear() before unref'ing fragments
skbuff: rename sock_zerocopy_* to msg_zerocopy_*
drivers/net/tap.c | 6 +-
drivers/net/tun.c | 6 +-
drivers/net/xen-netback/common.h | 3 +-
drivers/net/xen-netback/interface.c | 4 +-
drivers/net/xen-netback/netback.c | 7 ++-
drivers/vhost/net.c | 4 +-
include/linux/skbuff.h | 95 +++++++++++++++--------------
net/core/skbuff.c | 66 ++++++++++----------
net/ipv4/ip_output.c | 5 +-
net/ipv4/tcp.c | 8 +--
net/ipv6/ip6_output.c | 5 +-
net/kcm/kcmsock.c | 4 +-
12 files changed, 106 insertions(+), 107 deletions(-)
--
2.24.1
next reply other threads:[~2020-12-22 0:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 0:09 Jonathan Lemon [this message]
2020-12-22 0:09 ` [PATCH 01/12 v2 RFC] net: group skb_shinfo zerocopy related bits together Jonathan Lemon
2020-12-22 14:43 ` Willem de Bruijn
2020-12-22 17:21 ` Jonathan Lemon
2020-12-22 22:26 ` Willem de Bruijn
2020-12-22 22:40 ` Jonathan Lemon
2020-12-22 22:56 ` Willem de Bruijn
2020-12-22 0:09 ` [PATCH 02/12 v2 RFC] skbuff: remove unused skb_zcopy_abort function Jonathan Lemon
2020-12-22 15:00 ` Willem de Bruijn
2020-12-22 0:09 ` [PATCH 03/12 v2 RFC] skbuff: simplify sock_zerocopy_put Jonathan Lemon
2020-12-22 14:43 ` Willem de Bruijn
2020-12-22 16:52 ` David Ahern
2020-12-22 16:56 ` David Ahern
2020-12-22 0:09 ` [PATCH 04/12 v2 RFC] skbuff: Push status and refcounts into sock_zerocopy_callback Jonathan Lemon
2020-12-22 14:43 ` Willem de Bruijn
2020-12-22 16:49 ` David Ahern
2020-12-22 17:48 ` Jonathan Lemon
2020-12-22 22:38 ` Willem de Bruijn
2020-12-22 0:09 ` [PATCH 05/12 v2 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put() Jonathan Lemon
2020-12-22 14:42 ` Willem de Bruijn
2020-12-22 17:19 ` Jonathan Lemon
2020-12-22 22:36 ` Willem de Bruijn
2020-12-22 0:09 ` [PATCH 06/12 v2 RFC] skbuff: replace sock_zerocopy_get with skb_zcopy_get Jonathan Lemon
2020-12-22 0:09 ` [PATCH 07/12 v2 RFC] skbuff: Add skb parameter to the ubuf zerocopy callback Jonathan Lemon
2020-12-22 0:09 ` [PATCH 08/12 v2 RFC] skbuff: Call sock_zerocopy_put_abort from skb_zcopy_put_abort Jonathan Lemon
2020-12-22 0:09 ` [PATCH 09/12 v2 RFC] skbuff: add zc_flags to ubuf_info for ubuf setup Jonathan Lemon
2020-12-22 15:00 ` Willem de Bruijn
2020-12-22 18:17 ` Jonathan Lemon
2020-12-22 18:29 ` Willem de Bruijn
2020-12-22 0:09 ` [PATCH 10/12 v2 RFC] tap/tun: use skb_zcopy_set() instead of open coded assignment Jonathan Lemon
2020-12-22 0:09 ` [PATCH 11/12 v2 RFC] skbuff: Call skb_zcopy_clear() before unref'ing fragments Jonathan Lemon
2020-12-22 0:09 ` [PATCH 12/12 v2 RFC] skbuff: rename sock_zerocopy_* to msg_zerocopy_* Jonathan Lemon
2020-12-22 14:55 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222000926.1054993-1-jonathan.lemon@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=edumazet@google.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).