From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3A315C433DB
	for <netdev@archiver.kernel.org>; Fri, 25 Dec 2020 01:35:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id F2AFE20809
	for <netdev@archiver.kernel.org>; Fri, 25 Dec 2020 01:35:34 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729087AbgLYBfT (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 24 Dec 2020 20:35:19 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:40416 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729021AbgLYBfS (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 24 Dec 2020 20:35:18 -0500
Received: from andrew by vps0.lunn.ch with local (Exim 4.94)
        (envelope-from <andrew@lunn.ch>)
        id 1ksbzv-00DrmH-Lz; Fri, 25 Dec 2020 02:34:27 +0100
Date:   Fri, 25 Dec 2020 02:34:27 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Yuusuke Ashizuka <ashiduka@fujitsu.com>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org, torii.ken1@fujitsu.com
Subject: Re: [PATCH] net: phy: realtek: Add support for RTL9000AA/AN
Message-ID: <20201225013427.GV3107610@lunn.ch>
References: <20201225004751.26075-1-ashiduka@fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201225004751.26075-1-ashiduka@fujitsu.com>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> +static int rtl9000a_ack_interrupt(struct phy_device *phydev)
> +{
> +	int err;
> +
> +	err = phy_read(phydev, RTL8211F_INSR);
> +
> +	return (err < 0) ? err : 0;
> +}
> +
> +static int rtl9000a_config_intr(struct phy_device *phydev)
> +{
> +	u16 val;
> +
> +	if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
> +		val = (u16)~RTL9000A_GINMR_LINK_STATUS;
> +	else
> +		val = ~0;
> +
> +	return phy_write_paged(phydev, 0xa42, RTL9000A_GINMR, val);
> +}

You need to rework this for the recent change to interrupt handling.

    Andrew