From: Stephen Hemminger <stephen@networkplumber.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH iproute2 5.11 2/2] iplink_can: fix format output for details with statistics
Date: Sat, 26 Dec 2020 09:48:32 -0800 [thread overview]
Message-ID: <20201226094832.2b12a20e@hermes.local> (raw)
In-Reply-To: <20201225191015.3584-2-socketcan@hartkopp.net>
On Fri, 25 Dec 2020 20:10:15 +0100
Oliver Hartkopp <socketcan@hartkopp.net> wrote:
> @@ -315,10 +320,12 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
> "restart_ms",
> "restart-ms %d ",
> *restart_ms);
> }
>
> + fprintf(f, "\n ");
> +
That will print in both JSON and non-JSON mode. You don't want to do that.
It also will break in single-line mode.
The iplink_can code has way too many if (is_json_context()) ...
which can lead to differences in output.
Ideally it should have no instances of "fprintf(f, ..."
prev parent reply other threads:[~2020-12-26 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 19:10 [PATCH iproute2 5.11 1/2] iplink_can: add Classical CAN frame LEN8_DLC support Oliver Hartkopp
2020-12-25 19:10 ` [PATCH iproute2 5.11 2/2] iplink_can: fix format output for details with statistics Oliver Hartkopp
2020-12-26 17:48 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201226094832.2b12a20e@hermes.local \
--to=stephen@networkplumber.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).