From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A8CC433E0 for ; Sun, 27 Dec 2020 08:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ED2C207AB for ; Sun, 27 Dec 2020 08:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726121AbgL0Idr (ORCPT ); Sun, 27 Dec 2020 03:33:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:46716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgL0Idr (ORCPT ); Sun, 27 Dec 2020 03:33:47 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 24648207AB; Sun, 27 Dec 2020 08:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609057986; bh=wBte6beHPRpjRvAESlVnOERm+wcqSPP76lv0VK7bjb8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pbtv4OxAzXefuY8pMhqUz+S2jO1NwMIlUmRw23lkyLwqgj6bYk3vIvBEzbsmSidTV Eol2/ZBY4yYdlDb0CAx+cdKORPZbdm3RsOj2bFVsRUfClqmjMJlTXuYH9RjuKMDnyC KMYrnto7w8iXZvmIWEDV4IwV5CbkQhMgbnGj1QYx/6DvUWrIdOA7RyjbQUbEYH7Dab 7+EH7vaiJSaPq9R/wxX1cRHmINpJwJT/pUKhorNTudR3x1HVH5pOkciIWfRti5tpvN Z6bllFvEvhaj9Jkt1RPOe9SybBxTq+or9HrTIRz2SAU0MTToutYJteo0G9/iplIohv mVRtcajvAWkwg== Date: Sun, 27 Dec 2020 10:33:02 +0200 From: Leon Romanovsky To: Dinghao Liu Cc: kjlu@umn.edu, Saeed Mahameed , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups Message-ID: <20201227083302.GD4457@unreal> References: <20201221112731.32545-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201221112731.32545-1-dinghao.liu@zju.edu.cn> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 21, 2020 at 07:27:31PM +0800, Dinghao Liu wrote: > When mlx5_create_flow_group() fails, ft->g should be > freed just like when kvzalloc() fails. The caller of > mlx5e_create_l2_table_groups() does not catch this > issue on failure, which leads to memleak. > > Signed-off-by: Dinghao Liu > --- > drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 1 + > 1 file changed, 1 insertion(+) > Fixes: 33cfaaa8f36f ("net/mlx5e: Split the main flow steering table") Thanks, Reviewed-by: Leon Romanovsky