From: David Miller <davem@davemloft.net>
To: rdunlap@infradead.org
Cc: linux-kernel@vger.kernel.org,
syzbot+97c5bd9cc81eca63d36e@syzkaller.appspotmail.com,
nogahf@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH -net] net: sched: prevent invalid Scell_log shift count
Date: Mon, 28 Dec 2020 14:54:01 -0800 (PST) [thread overview]
Message-ID: <20201228.145401.2067471886598959966.davem@davemloft.net> (raw)
In-Reply-To: <20201225062344.32566-1-rdunlap@infradead.org>
From: Randy Dunlap <rdunlap@infradead.org>
Date: Thu, 24 Dec 2020 22:23:44 -0800
> Check Scell_log shift size in red_check_params() and modify all callers
> of red_check_params() to pass Scell_log.
>
> This prevents a shift out-of-bounds as detected by UBSAN:
> UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22
> shift exponent 72 is too large for 32-bit type 'int'
>
> Fixes: 8afa10cbe281 ("net_sched: red: Avoid illegal values")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: syzbot+97c5bd9cc81eca63d36e@syzkaller.appspotmail.com
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-12-28 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 6:23 [PATCH -net] net: sched: prevent invalid Scell_log shift count Randy Dunlap
2020-12-28 22:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228.145401.2067471886598959966.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=rdunlap@infradead.org \
--cc=syzbot+97c5bd9cc81eca63d36e@syzkaller.appspotmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).