From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, cong.wang@bytedance.com,
syzbot+f583ce3d4ddf9836b27a@syzkaller.appspotmail.com,
u9012063@gmail.com, lorenzo.bianconi@redhat.com
Subject: Re: [Patch net] erspan: fix version 1 check in gre_parse_header()
Date: Mon, 28 Dec 2020 15:01:03 -0800 (PST) [thread overview]
Message-ID: <20201228.150103.7398661656696572.davem@davemloft.net> (raw)
In-Reply-To: <20201226234453.905884-1-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Sat, 26 Dec 2020 15:44:53 -0800
> From: Cong Wang <cong.wang@bytedance.com>
>
> Both version 0 and version 1 use ETH_P_ERSPAN, but version 0 does not
> have an erspan header. So the check in gre_parse_header() is wrong,
> we have to distinguish version 1 from version 0.
>
> We can just check the gre header length like is_erspan_type1().
>
> Fixes: cb73ee40b1b3 ("net: ip_gre: use erspan key field for tunnel lookup")
> Reported-by: syzbot+f583ce3d4ddf9836b27a@syzkaller.appspotmail.com
> Cc: William Tu <u9012063@gmail.com>
> Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-12-28 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 23:44 [Patch net] erspan: fix version 1 check in gre_parse_header() Cong Wang
2020-12-28 23:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228.150103.7398661656696572.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cong.wang@bytedance.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+f583ce3d4ddf9836b27a@syzkaller.appspotmail.com \
--cc=u9012063@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).