From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D413C433E6 for ; Mon, 28 Dec 2020 23:02:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3EE7222F9 for ; Mon, 28 Dec 2020 23:01:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728242AbgL1XBp (ORCPT ); Mon, 28 Dec 2020 18:01:45 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44800 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727799AbgL1XBo (ORCPT ); Mon, 28 Dec 2020 18:01:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 93C5D4CE686E0; Mon, 28 Dec 2020 15:01:03 -0800 (PST) Date: Mon, 28 Dec 2020 15:01:03 -0800 (PST) Message-Id: <20201228.150103.7398661656696572.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: netdev@vger.kernel.org, cong.wang@bytedance.com, syzbot+f583ce3d4ddf9836b27a@syzkaller.appspotmail.com, u9012063@gmail.com, lorenzo.bianconi@redhat.com Subject: Re: [Patch net] erspan: fix version 1 check in gre_parse_header() From: David Miller In-Reply-To: <20201226234453.905884-1-xiyou.wangcong@gmail.com> References: <20201226234453.905884-1-xiyou.wangcong@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Mon, 28 Dec 2020 15:01:03 -0800 (PST) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Sat, 26 Dec 2020 15:44:53 -0800 > From: Cong Wang > > Both version 0 and version 1 use ETH_P_ERSPAN, but version 0 does not > have an erspan header. So the check in gre_parse_header() is wrong, > we have to distinguish version 1 from version 0. > > We can just check the gre header length like is_erspan_type1(). > > Fixes: cb73ee40b1b3 ("net: ip_gre: use erspan key field for tunnel lookup") > Reported-by: syzbot+f583ce3d4ddf9836b27a@syzkaller.appspotmail.com > Cc: William Tu > Cc: Lorenzo Bianconi > Signed-off-by: Cong Wang Applied and queued up for -stable, thanks.