netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taehee Yoo <ap420073@gmail.com>
To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org
Cc: ap420073@gmail.com, gnault@redhat.com
Subject: [PATCH net v2 0/2] bareudp: fix several issues
Date: Mon, 28 Dec 2020 15:21:21 +0000	[thread overview]
Message-ID: <20201228152121.24160-1-ap420073@gmail.com> (raw)

This patchset is to fix problems when bareudp is used nestedly.

1. If the NETIF_F_LLTX flag is not set, the lockdep warns about
a possible deadlock scenario when bareudp interfaces are used nestedly.
But, like other tunneling interfaces, bareudp doesn't need xmit lock.
So, it sets NETIF_F_LLTTX.
Lockdep no more warns about a possible deadlock scenario.

2. bareudp interface calculates min_headroom when it sends a packet.
When it calculates min_headroom, it uses the size of struct iphdr even
the ipv6 packet is going to be sent.
It would result in a lack of headroom so eventually occurs kernel panic.

Changelog
v1 -> v2:
 - Change reproducer script in 1/2 patch.
 - Fix reproducer script in 2/2 patch.

Taehee Yoo (2):
  bareudp: set NETIF_F_LLTX flag
  bareudp: Fix use of incorrect min_headroom size

 drivers/net/bareudp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1


             reply	other threads:[~2020-12-28 15:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 15:21 Taehee Yoo [this message]
2021-01-04 21:14 ` [PATCH net v2 0/2] bareudp: fix several issues Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201228152121.24160-1-ap420073@gmail.com \
    --to=ap420073@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gnault@redhat.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).