netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Zhao Qiang <qiang.zhao@nxp.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Xie He <xie.he.0141@gmail.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 7/7] wan: ds26522: select CONFIG_BITREVERSE
Date: Sun,  3 Jan 2021 22:36:23 +0100	[thread overview]
Message-ID: <20210103213645.1994783-7-arnd@kernel.org> (raw)
In-Reply-To: <20210103213645.1994783-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

Without this, the driver runs into a link failure

arm-linux-gnueabi-ld: drivers/net/wan/slic_ds26522.o: in function `slic_ds26522_probe':
slic_ds26522.c:(.text+0x100c): undefined reference to `byte_rev_table'
arm-linux-gnueabi-ld: slic_ds26522.c:(.text+0x1cdc): undefined reference to `byte_rev_table'
arm-linux-gnueabi-ld: drivers/net/wan/slic_ds26522.o: in function `slic_write':
slic_ds26522.c:(.text+0x1e4c): undefined reference to `byte_rev_table'

Fixes: c37d4a0085c5 ("Maxim/driver: Add driver for maxim ds26522")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wan/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
index 8931ef529065..a187c814a4a6 100644
--- a/drivers/net/wan/Kconfig
+++ b/drivers/net/wan/Kconfig
@@ -282,6 +282,7 @@ config SLIC_DS26522
 	tristate "Slic Maxim ds26522 card support"
 	depends on SPI
 	depends on FSL_SOC || ARCH_MXC || ARCH_LAYERSCAPE || COMPILE_TEST
+	select BITREVERSE
 	help
 	  This module initializes and configures the slic maxim card
 	  in T1 or E1 mode.
-- 
2.29.2


      parent reply	other threads:[~2021-01-03 21:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03 21:36 [PATCH 1/7] qed: select CONFIG_CRC32 Arnd Bergmann
2021-01-03 21:36 ` [PATCH 2/7] phy: dp83640: " Arnd Bergmann
2021-01-03 23:09   ` Andrew Lunn
2021-01-04 13:03   ` Richard Cochran
2021-01-03 21:36 ` [PATCH 3/7] can: kvaser_pciefd: " Arnd Bergmann
2021-01-04  8:43   ` Marc Kleine-Budde
2021-01-03 21:36 ` [PATCH 4/7] wil6210: " Arnd Bergmann
2021-01-11 11:47   ` Kalle Valo
2021-01-14 18:45   ` Kalle Valo
2021-01-03 21:36 ` [PATCH 5/7] cfg80211: " Arnd Bergmann
2021-01-03 21:36 ` [PATCH 6/7] misdn: dsp: select CONFIG_BITREVERSE Arnd Bergmann
2021-01-03 21:36 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210103213645.1994783-7-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=qiang.zhao@nxp.com \
    --cc=xie.he.0141@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).