From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net v2] docs: net: fix documentation on .ndo_get_stats
Date: Tue, 5 Jan 2021 13:51:49 +0200 [thread overview]
Message-ID: <20210105115149.f64yqrup6rxte4dh@skbuf> (raw)
In-Reply-To: <20210105012224.1681573-1-kuba@kernel.org>
On Mon, Jan 04, 2021 at 05:22:24PM -0800, Jakub Kicinski wrote:
> Fix calling context.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Documentation/networking/netdevices.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
> index 5a85fcc80c76..e65665c5ab50 100644
> --- a/Documentation/networking/netdevices.rst
> +++ b/Documentation/networking/netdevices.rst
> @@ -64,8 +64,8 @@ struct net_device synchronization rules
> Context: process
>
> ndo_get_stats:
> - Synchronization: dev_base_lock rwlock.
> - Context: nominally process, but don't sleep inside an rwlock
> + Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
> + Context: atomic (can't sleep under rwlock or RCU)
>
> ndo_start_xmit:
> Synchronization: __netif_tx_lock spinlock.
> --
> 2.26.2
>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
next prev parent reply other threads:[~2021-01-05 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 1:22 [PATCH net v2] docs: net: fix documentation on .ndo_get_stats Jakub Kicinski
2021-01-05 11:51 ` Vladimir Oltean [this message]
2021-01-06 0:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105115149.f64yqrup6rxte4dh@skbuf \
--to=olteanv@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).