From: "Marek Behún" <kabel@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Jakub Kicinski <kuba@kernel.org>,
Sven Auhagen <sven.auhagen@voleatech.de>,
Matteo Croce <mcroce@microsoft.com>,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH net-next] net: mvpp2: increase MTU limit when XDP enabled
Date: Wed, 6 Jan 2021 13:11:40 +0100 [thread overview]
Message-ID: <20210106131140.44768b25@kernel.org> (raw)
In-Reply-To: <X/TKsHr+8U82kwAz@lunn.ch>
On Tue, 5 Jan 2021 21:23:12 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> > @@ -4913,8 +4914,8 @@ static int mvpp2_xdp_setup(struct mvpp2_port *port, struct netdev_bpf *bpf)
> > bool running = netif_running(port->dev);
> > bool reset = !prog != !port->xdp_prog;
> >
> > - if (port->dev->mtu > ETH_DATA_LEN) {
> > - NL_SET_ERR_MSG_MOD(bpf->extack, "XDP is not supported with jumbo frames enabled");
> > + if (port->dev->mtu > MVPP2_MAX_RX_BUF_SIZE) {
> > + NL_SET_ERR_MSG_MOD(bpf->extack, "MTU too large for XDP");
>
> Hi Marek
>
> Since MVPP2_MAX_RX_BUF_SIZE is a constant, you can probably do some
> CPP magic and have it part of the extack message, to give the user a
> clue what the maximum is.
>
> Andrew
It is a constant that is computed using sizeof of some structs. I don't
know if that can be converted at compile-time to string (it should be,
theoretically, but I don't know if compiler allows it).
prev parent reply other threads:[~2021-01-06 12:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 17:19 [PATCH net-next] net: mvpp2: increase MTU limit when XDP enabled Marek Behún
2021-01-05 17:24 ` Sven Auhagen
2021-01-05 17:43 ` Marek Behún
2021-01-05 20:21 ` Andrew Lunn
2021-01-06 11:56 ` Marek Behún
2021-01-06 12:32 ` Marek Behún
2021-01-06 12:33 ` Marek Behún
2021-01-06 18:34 ` Andrew Lunn
2021-01-06 13:13 ` Vladimir Oltean
2021-01-06 10:33 ` Jesper Dangaard Brouer
2021-01-06 11:28 ` Sven Auhagen
2021-01-05 20:23 ` Andrew Lunn
2021-01-06 12:11 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106131140.44768b25@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=mcroce@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sven.auhagen@voleatech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).