From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E2A5C433E0 for ; Wed, 6 Jan 2021 18:12:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DED072312C for ; Wed, 6 Jan 2021 18:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726795AbhAFSLp (ORCPT ); Wed, 6 Jan 2021 13:11:45 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:50703 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbhAFSLo (ORCPT ); Wed, 6 Jan 2021 13:11:44 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 18D5D580659; Wed, 6 Jan 2021 13:10:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 06 Jan 2021 13:10:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=JgBPFn 6+I1DS6lctzlSVx7dJzScz0EO1ksQI4/wmg+w=; b=BZ3+tqPrwO6VVk/LSO5bBc yLk2QuVwHUceZwJ1pLiEsr3yYeiEEQJXgZp+WSLEr1u7L6U+jsyqxVlMZeCg3nDM VC+kD9DwdX66bxUTo2IUHBRCZf45eQKCzccCfXmEO8g+ZOOEKrX9uDO+w1CG3Ep8 gul/pRJZRt35I1x6brGBfKH5Q04sgMeqKnLweG/EwQG2WBq1Q+FMdg0RikgwLMUq 6TRl4n7Aeuoo8mGIK/j277bPv9pwn17SOLmS6LrBherOCa3vaAxS05JHcC2LANQI rHpZ8CGDtBKAWqK2RAOEELRZ3XuyKzkoeR1H1Z0Qtk5K4EH9DqaNVrBy1v18PtVA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdegtddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedtffekkeefudffveegueejffejhfetgfeuuefgvedtieehudeuueekhfduheel teenucfkphepkeegrddvvdelrdduheefrdeggeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (igld-84-229-153-44.inter.net.il [84.229.153.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 76C05108005C; Wed, 6 Jan 2021 13:10:33 -0500 (EST) Date: Wed, 6 Jan 2021 20:10:30 +0200 From: Ido Schimmel To: Vladimir Oltean Cc: "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , Microchip Linux Driver Support , Sean Wang , Landen Chao , Claudiu Manoil , Alexandre Belloni , Linus Walleij , Vadym Kochan , Taras Chornyi , Jiri Pirko , Ido Schimmel , Grygorii Strashko , Ioana Ciornei , Ivan Vecera Subject: Re: [PATCH v2 net-next 09/10] mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects Message-ID: <20210106181030.GD1082997@shredder.lan> References: <20210106131006.577312-1-olteanv@gmail.com> <20210106131006.577312-10-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210106131006.577312-10-olteanv@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 06, 2021 at 03:10:05PM +0200, Vladimir Oltean wrote: > @@ -1764,29 +1759,20 @@ static int mlxsw_sp_port_obj_add(struct net_device *dev, > { > struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev); > const struct switchdev_obj_port_vlan *vlan; > - struct switchdev_trans trans; > int err = 0; > > switch (obj->id) { > case SWITCHDEV_OBJ_ID_PORT_VLAN: > vlan = SWITCHDEV_OBJ_PORT_VLAN(obj); > > - trans.ph_prepare = true; > - err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, &trans, > - extack); > + err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, extack); > if (err) > break; > > - /* The event is emitted before the changes are actually > - * applied to the bridge. Therefore schedule the respin > - * call for later, so that the respin logic sees the > + /* Schedule the respin call, so that the respin logic sees the > * updated bridge state. > */ I would keep this comment as-is. Other than that this patch looks good to me: Reviewed-by: Ido Schimmel Thanks