From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Oz Shlomo <ozsh@nvidia.com>,
Roi Dayan <roid@nvidia.com>, Paul Blakey <paulb@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [net 04/11] net/mlx5e: CT: Use per flow counter when CT flow accounting is enabled
Date: Thu, 7 Jan 2021 19:04:40 -0300 [thread overview]
Message-ID: <20210107220440.GD8313@horizon.localdomain> (raw)
In-Reply-To: <20210107202845.470205-5-saeed@kernel.org>
On Thu, Jan 07, 2021 at 12:28:38PM -0800, Saeed Mahameed wrote:
> From: Oz Shlomo <ozsh@nvidia.com>
>
> Connection counters may be shared for both directions when the counter
> is used for connection aging purposes. However, if TC flow
> accounting is enabled then a unique counter is required per direction.
>
> Instantiate a unique counter per direction if the conntrack accounting
> extension is enabled. Use a shared counter when the connection accounting
> extension is disabled.
>
> Fixes: 1edae2335adf ("net/mlx5e: CT: Use the same counter for both directions")
> Signed-off-by: Oz Shlomo <ozsh@nvidia.com>
> Reported-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Tested-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Thanks.
> Reviewed-by: Roi Dayan <roid@nvidia.com>
> Reviewed-by: Paul Blakey <paulb@nvidia.com>
> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
next prev parent reply other threads:[~2021-01-07 22:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 20:28 [pull request][net 00/11] mlx5 fixes 2021-01-07 Saeed Mahameed
2021-01-07 20:28 ` [net 01/11] net/mlx5: Check if lag is supported before creating one Saeed Mahameed
2021-01-07 20:28 ` [net 02/11] net/mlx5e: Add missing capability check for uplink follow Saeed Mahameed
2021-01-07 20:28 ` [net 03/11] net/mlx5: Use port_num 1 instead of 0 when delete a RoCE address Saeed Mahameed
2021-01-07 20:28 ` [net 04/11] net/mlx5e: CT: Use per flow counter when CT flow accounting is enabled Saeed Mahameed
2021-01-07 22:04 ` Marcelo Ricardo Leitner [this message]
2021-01-08 3:07 ` Jakub Kicinski
2021-01-08 4:06 ` Saeed Mahameed
2021-01-08 4:18 ` Saeed Mahameed
2021-01-08 4:40 ` Jakub Kicinski
2021-01-08 4:56 ` Saeed Mahameed
2021-01-07 20:28 ` [net 05/11] net/mlx5e: Fix SWP offsets when vlan inserted by driver Saeed Mahameed
2021-01-08 3:08 ` Jakub Kicinski
2021-01-08 4:07 ` Saeed Mahameed
2021-01-07 20:28 ` [net 06/11] net/mlx5: E-Switch, fix changing vf VLANID Saeed Mahameed
2021-01-07 20:28 ` [net 07/11] net/mlx5e: In skb build skip setting mark in switchdev mode Saeed Mahameed
2021-01-07 20:28 ` [net 08/11] net/mlx5e: ethtool, Fix restriction of autoneg with 56G Saeed Mahameed
2021-01-07 20:28 ` [net 09/11] net/mlx5: Release devlink object if adev fails Saeed Mahameed
2021-01-07 20:28 ` [net 10/11] net/mlx5e: Fix two double free cases Saeed Mahameed
2021-01-07 20:28 ` [net 11/11] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups Saeed Mahameed
2021-01-08 3:18 ` [pull request][net 00/11] mlx5 fixes 2021-01-07 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107220440.GD8313@horizon.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=paulb@nvidia.com \
--cc=roid@nvidia.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox