From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 1/2] ice: drop dead code in ice_receive_skb()
Date: Fri, 8 Jan 2021 11:33:54 -0800 [thread overview]
Message-ID: <20210108113354.00000dd9@intel.com> (raw)
In-Reply-To: <20210108113903.3779510-2-eric.dumazet@gmail.com>
Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> napi_gro_receive() can never return GRO_DROP
>
> GRO_DROP can only be returned from napi_gro_frags()
> which is the other NAPI GRO entry point.
>
> Followup patch will remove GRO_DROP, because drivers
> are not supposed to call napi_gro_frags() if prior
> napi_get_frags() has failed.
>
> Note that I have left the gro_dropped variable. I leave to ice
> maintainers the decision to further remove it from ethtool -S results.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Jakub or David, you're welcome to apply directly as part of this series.
The original code went into the kernel right as the code to remove
GRO_DROP returns went in just before, but the reviews crossed each
other and no-one (especially me :-( ) caught it.
for reference:
commit 0e00c05fa72554c86d7c7e0f538ec83bfe277c91
Merge: b18e9834f7b2 045790b7bc66
Author: David S. Miller <davem@davemloft.net>
Date: Thu Jun 25 16:16:21 2020 -0700
Subject: Merge branch 'napi_gro_receive-caller-return-value-cleanups'
next prev parent reply other threads:[~2021-01-08 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 11:39 [PATCH net-next 0/2] net-gro: GRO_DROP deprecation Eric Dumazet
2021-01-08 11:39 ` [PATCH net-next 1/2] ice: drop dead code in ice_receive_skb() Eric Dumazet
2021-01-08 19:33 ` Jesse Brandeburg [this message]
2021-01-08 11:39 ` [PATCH net-next 2/2] net-gro: remove GRO_DROP Eric Dumazet
2021-01-08 12:32 ` Edward Cree
2021-01-10 0:10 ` [PATCH net-next 0/2] net-gro: GRO_DROP deprecation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108113354.00000dd9@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).